Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-143672: Add more tests for struct.pack_into()#143901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJan 16, 2026•
edited by bedevere-appbot
Loading

Add tests for negative offset, out of bound offset, invalid type of offset, non-writeable buffer, non-continuous buffer, invalid type of buffer.

Repeat all tests for struct.Struct.pack_into().

Add tests for negative offset, out of bound offset, invalid type of offset,non-writeable buffer, non-continuous buffer, invalid type of buffer.Repeat all tests for struct.Struct.pack_into().
@serhiy-storchakaserhiy-storchaka added testsTests in the Lib/test dir skip news needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJan 16, 2026
@skirpichevskirpichev changed the titleAdd more tests for struct.pack_into()gh-143672: Add more tests for struct.pack_into()Jan 16, 2026
Copy link
Member

@skirpichevskirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@serhiy-storchakaserhiy-storchakaenabled auto-merge (squash)January 16, 2026 11:05
@serhiy-storchakaserhiy-storchaka merged commit66680f1 intopython:mainJan 16, 2026
55 checks passed
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 16, 2026
Add tests for negative offset, out of bound offset, invalid type of offset,non-writeable buffer, non-continuous buffer, invalid type of buffer.Repeat all tests for struct.Struct.pack_into().(cherry picked from commit66680f1)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 16, 2026
Add tests for negative offset, out of bound offset, invalid type of offset,non-writeable buffer, non-continuous buffer, invalid type of buffer.Repeat all tests for struct.Struct.pack_into().(cherry picked from commit66680f1)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-143902 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJan 16, 2026
@bedevere-app
Copy link

GH-143903 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 16, 2026
serhiy-storchaka added a commit that referenced this pull requestJan 16, 2026
…H-143903)Add tests for negative offset, out of bound offset, invalid type of offset,non-writeable buffer, non-continuous buffer, invalid type of buffer.Repeat all tests for struct.Struct.pack_into().(cherry picked from commit66680f1)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestJan 16, 2026
…H-143902)Add tests for negative offset, out of bound offset, invalid type of offset,non-writeable buffer, non-continuous buffer, invalid type of buffer.Repeat all tests for struct.Struct.pack_into().(cherry picked from commit66680f1)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@skirpichevskirpichevskirpichev approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka@skirpichev
[8]ページ先頭
©2009-2026 Movatter.jp