Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-143897: Remove the isxidstart() and isxidcontinue() methods of unicodedata.ucd_3_2_0#143898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJan 16, 2026•
edited by bedevere-appbot
Loading

They are now only exposed as the unicodedata function.

…of unicodedata.ucd_3_2_0They are now only exposed as the unicodedata function.
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. I didn't notice that isxidstart() and isxidcontinue() were added to unicodedata.ucd_3_2_0. I don't think that we need them, so they can be removed.

@serhiy-storchaka
Copy link
MemberAuthor

At the time they were added, there was no precedence and mechanism to add only function tounicodedata without adding a method tounicodedata.ucd_3_2_0. So this is understandable.

StanFromIreland reacted with thumbs up emoji

@StanFromIreland
Copy link
Member

Yes, that is why I added the fast-path instead.

Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

…WJBHN.rstCo-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@serhiy-storchakaserhiy-storchakaenabled auto-merge (squash)January 19, 2026 12:13
@serhiy-storchakaserhiy-storchaka merged commitbb2b9ba intopython:mainJan 19, 2026
47 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@StanFromIreland@vstinner@encukou
[8]ページ先頭
©2009-2026 Movatter.jp