Thank you for your interest in this! I encourage you to open a new issue if you think like the performance ofForwardRef.__hash__ can and should be improved. I'm afraid it is out of scope of this surgical PR -- I will not be addressing anything outside the topic of cell comparison.

Regarding why I solved it this way -- I just went with what the original intent was but with a corrected assumption about the hashability of cells.

cc@JelleZijlstra

If the performance of some part of the typing stack is a problem for you, please open a concise issue with concrete examples of what you would like to change. (Digressions on the beauty of the wilds of Canada are not necessary.)

I've considered simply basing things on the identity of__cell__ (even as dict) but this wouldn't make sense because_build_closure creates a new dict object everytime. Two calls subsequent toget_annotations() on the same symbol should produce forward references that are fully equal; the current implementation is sound.

I don't know what's wrong with CI, I'll update the branch to see if it helps.

Thanks@johnslavik for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

GH-144020 is a backport of this pull request to the3.14 branch.

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 macOS 3.14 (tier-2) has failed when building commit2147d3f.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1772/builds/817) and take a look at the build logs.
4. Check if the failure is related to this commit (2147d3f) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1772/builds/817

Failed tests:

• test_urllib2net

Summary of the results of the build (if available):

==

remote:Enumerating objects: 11, done.remote:Counting objects:  10% (1/10)remote:Counting objects:  20% (2/10)remote:Counting objects:  30% (3/10)remote:Counting objects:  40% (4/10)remote:Counting objects:  50% (5/10)remote:Counting objects:  60% (6/10)remote:Counting objects:  70% (7/10)remote:Counting objects:  80% (8/10)remote:Counting objects:  90% (9/10)remote:Counting objects: 100% (10/10)remote:Counting objects: 100% (10/10), done.remote:Compressing objects:  33% (1/3)remote:Compressing objects:  66% (2/3)remote:Compressing objects: 100% (3/3)remote:Compressing objects: 100% (3/3), done.remote:Total 11 (delta 7), reused 7 (delta 7), pack-reused 1 (from 1)From https://github.com/python/cpython * branch                    3.14       -> FETCH_HEADNote:switching to '2147d3fa2b25e390462e859abb4d791ce07496c7'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 2147d3fa2b2 [3.14] gh-143831: Compare cells by identity in forward references (GH-143848) (#144020)Switched to and reset branch '3.14'make:*** [buildbottest] Error 2