Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-143754: Use neutral terminology in tkinter documentation#143779

Closed
VanshAgarwal24036 wants to merge 2 commits intopython:mainfrom
VanshAgarwal24036:gh-143754-tkinter-neutral-terms
Closed

gh-143754: Use neutral terminology in tkinter documentation#143779
VanshAgarwal24036 wants to merge 2 commits intopython:mainfrom
VanshAgarwal24036:gh-143754-tkinter-neutral-terms

Conversation

@VanshAgarwal24036
Copy link
Contributor

@VanshAgarwal24036VanshAgarwal24036 commentedJan 13, 2026
edited by bedevere-appbot
Loading

This PR updates the tkinter documentation to replace the term “slave” with
neutral alternatives such as “child widget”.

The changes are limited to documentation wording only and do not affect
APIs or behavior.

Fixes#143754.


📚 Documentation preview 📚:https://cpython-previews--143779.org.readthedocs.build/

@VanshAgarwal24036VanshAgarwal24036 changed the titleGh 143754 tkinter neutral termsgh-143754: Use neutral terminology in tkinter documentationJan 13, 2026
@VanshAgarwal24036VanshAgarwal24036force-pushed thegh-143754-tkinter-neutral-terms branch from102c344 tof50a321CompareJanuary 13, 2026 09:30
@VanshAgarwal24036
Copy link
ContributorAuthor

This PR is documentation-only, so it does not require a NEWS entry.
Could a maintainer please add theskip news label?

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@VanshAgarwal24036
Copy link
ContributorAuthor

Thanks for the clarification.

I’ve updated the paragraph to keepmaster for the container relationship
while removingslave, and adjusted the wording to stay within the scope
of this PR. I also fixed thewinfo_parent markup warning.

Please let me know if this looks good now.

@VanshAgarwal24036
Copy link
ContributorAuthor

VanshAgarwal24036 commentedJan 14, 2026
edited
Loading

@terryjreedy I have commited the suggested changes Please review and suggest if any change required

@picnixz
Copy link
Member

I think Serhiy's PR addresses this already and in a better way. What has changed between these two PRs? I would also prefer Serhiy's PR as he has deep tkinter knowledge.

@VanshAgarwal24036
Copy link
ContributorAuthor

Thanks for the clarification. Since Serhiy’s PR already covers this,
I’m happy to defer. Let me know if you’d like me to close this PR or
if you prefer to handle it.

@terryjreedy
Copy link
Member

Thank you for starting this. Serhiy went back to the current tk docs for both docstrings and tkinter.rst.

@VanshAgarwal24036VanshAgarwal24036 deleted the gh-143754-tkinter-neutral-terms branchJanuary 19, 2026 07:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rhettingerrhettingerAwaiting requested review from rhettinger

@terryjreedyterryjreedyAwaiting requested review from terryjreedy

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tkinter source and docs use the word 'slave'

4 participants

@VanshAgarwal24036@picnixz@terryjreedy@aisk

[8]ページ先頭

©2009-2026 Movatter.jp