Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-143460: Correct unlimited stack size skip for Emscripten#143765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
freakboy3742 commentedJan 13, 2026
!buildbot emscripten |
bedevere-bot commentedJan 13, 2026
🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commit43b53af 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143765%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
| ifis_emscriptenoris_wasioros.name=="nt": | ||
| returntest | ||
| importresource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Another option is to removeif is_wasi or os.name == "nt": and replace it with a more a generic:
| importresource | |
| try: | |
| importresource | |
| exceptImportError: | |
| returntest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thought about that approach, but I figured it would be better to be explicit about whenresource is a required module so that you catch a case whereresource fails to compile for some reason.
1857a40 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…thonGH-143765)Modifies the test skip for unlimited stack size to add Emscripten to theexclusion list.(cherry picked from commit1857a40)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
GH-143819 is a backport of this pull request to the3.14 branch. |
Uh oh!
There was an error while loading.Please reload this page.
#143606 added a test skip decorator for tests when an infinite stack size is configured. That test skip included a shortcut for WASI (which doesn't have a
resourcemodule), but missing Emscripten (which has the same limitation).test_functools/test_json#143460