Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-143572: Run 'python3-libraries' fuzzer in CI using CIFuzz#143749

Merged
hugovk merged 12 commits intopython:mainfrom
sethmlarson:detect-library-fuzzers-for-prs
Jan 16, 2026
Merged

gh-143572: Run 'python3-libraries' fuzzer in CI using CIFuzz#143749
hugovk merged 12 commits intopython:mainfrom
sethmlarson:detect-library-fuzzers-for-prs

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarsonsethmlarson commentedJan 12, 2026
edited by bedevere-appbot
Loading

Created a list of files and directories that should trigger a re-run of thepython3-libraries fuzzers. Now that the Python repository is the home for this fuzzer it should be easier for Python core developers to fix issues with the fuzzer in case there are issues.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we could also rename most of the "library"/"libraries"/"LIBRARY" to "stdlib"/"STDLIB" and it'd be clearer this is running on the standard library and not any third-party library code.

@sethmlarson
Copy link
ContributorAuthor

I think we could also rename most of the "library"/"libraries"/"LIBRARY" to "stdlib"/"STDLIB" and it'd be clearer this is running on the standard library and not any third-party library code.

I agree with this, we can change most of our uses to "stdlib" within this PR except foross-fuzz-project-name. I can handle that in a separate PR since we'll have to wait for OSS-Fuzz maintainers to rename the project.

@sethmlarson
Copy link
ContributorAuthor

Thanks@StanFromIreland and@hugovk for the reviews! I've moved to a reusable workflows approach. I'll try pushing a commit modifying one of the libraries to check that the workflow fires correctly.

@hugovk
Copy link
Member

(I resolved the conflict)

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <578543+webknjaz@users.noreply.github.com>
@sethmlarson
Copy link
ContributorAuthor

@webknjaz I'm not sure why actionlint is refusing thecontains([...], 'true') syntax used, checking on theallowed function definitions it seemed like this would be allowed?

@sethmlarson
Copy link
ContributorAuthor

With the latest commit we got a run, but the values ofoss-fuzz-project-name andsanitizer aren't being forwarded (the reusable workflow is seeing an empty string?) from the job matrix into the reusable workflow. I don't think I'm doing anything different than any of the other reusable workflows that use a matrix and forward parameters?

@webknjaz
Copy link
Member

@webknjaz I'm not sure why actionlint is refusing thecontains([...], 'true') syntax used, checking on theallowed function definitions it seemed like this would be allowed?

Not sure. Might be a bug in actionlint. Or maybe I misunderstood that this'd work from the docs 🤷‍♂️

@webknjaz
Copy link
Member

With the latest commit we got a run, but the values ofoss-fuzz-project-name andsanitizer aren't being forwarded (the reusable workflow is seeing an empty string?) from the job matrix into the reusable workflow. I don't think I'm doing anything different than any of the other reusable workflows that use a matrix and forward parameters?

Sounds like maybe I messed up the suggested conditionals or something. I'll double-check the current diff.

@webknjazwebknjaz added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJan 15, 2026
@webknjaz
Copy link
Member

One more thing — in general, it's a good idea to keep the CI infra the same (at least structurally) across branches since this will reduce conflicts when backporting more important changes. So this will need to be backported if possible. Either partially or, if there's no problems — in full. The backwards compat considerations would almost never apply to the CI infra the same way it'd apply to the user-facing changes.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@hugovk
Copy link
Member

hugovk commentedJan 16, 2026
edited
Loading

A brief note on CI time. These three jobs take about 22 minutes, which is fine:

  • CIFuzz / python3-libraries (undefined) 22m 36s
  • CIFuzz / python3-libraries (address) 20m 38s
  • CIFuzz / python3-libraries (memory) 22m 14s

https://github.com/python/cpython/actions/runs/21006197138/usage

We have a few other jobs taking around this long, like Android and iOS and some Windows ones, with one free-threaded Windows being the bottleneck at 32 mins.

image

Just something to keep an eye on.

sethmlarson reacted with thumbs up emoji

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks all!

sethmlarson and webknjaz reacted with heart emoji
@hugovkhugovk merged commitedeebe2 intopython:mainJan 16, 2026
61 checks passed
@github-project-automationgithub-project-automationbot moved this from🧐 @webknjaz's review queue 📋 to🌈 Done 🦄 in📅 Procrastinating in public 😵‍💫Jan 16, 2026
@miss-islington-app
Copy link

Thanks@sethmlarson for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@sethmlarson and@hugovk, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker edeebe22cb6bff3df4196bef3dcbdc7044f54df6 3.14

@miss-islington-app
Copy link

Sorry,@sethmlarson and@hugovk, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker edeebe22cb6bff3df4196bef3dcbdc7044f54df6 3.13

@sethmlarson
Copy link
ContributorAuthor

@hugovk I can work on creating backports. Thanks for the reviews, everyone!

hugovk reacted with thumbs up emoji

@bedevere-app
Copy link

GH-143912 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJan 16, 2026
sethmlarson added a commit to sethmlarson/cpython that referenced this pull requestJan 16, 2026
…Fuzz (pythonGH-143749)(cherry picked from commitedeebe2)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <578543+webknjaz@users.noreply.github.com>Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-143915 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 16, 2026
@sethmlarsonsethmlarson deleted the detect-library-fuzzers-for-prs branchJanuary 16, 2026 16:41
runs-on: ubuntu-latest
timeout-minutes: 60
# ${{ '' } is a hack to nest jobs under the same sidebar category.
name: CIFuzz${{ '' }} # zizmor: ignore[obfuscation]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reflecting on this a bit, I think we could've interpolated one of the factors to produce separate categories.

-     name: CIFuzz${{ '' }}  # zizmor: ignore[obfuscation]+     name: CIFuzz (${{ matrix.oss-fuzz-project-name }})

We can still do this in follow-ups if you@sethmlarson think it's a good idea.

@StanFromIreland
Copy link
Member

A brief note on CI time. These three jobs take about 22 minutes, which is fine:

Sometimes... This run is over an hour:https://github.com/python/cpython/actions/runs/21520243325/job/62009161712?pr=144293

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull requestFeb 15, 2026
…ython#143749)Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <578543+webknjaz@users.noreply.github.com>Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@webknjazwebknjazwebknjaz approved these changes

@hugovkhugovkhugovk approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@picnixzpicnixzAwaiting requested review from picnixz

@StanFromIrelandStanFromIrelandAwaiting requested review from StanFromIreland

Assignees

@hugovkhugovk

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sethmlarson@hugovk@webknjaz@StanFromIreland@picnixz

[8]ページ先頭

©2009-2026 Movatter.jp