Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-144194: Fix mmap failure check in perf_jit_trampoline.c#143713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromstratakis:mmap
Jan 28, 2026

Conversation

@stratakis
Copy link
Contributor

@stratakisstratakis commentedJan 11, 2026•
edited by bedevere-appbot
Loading

mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The current check never detects mmap failures, so jitdump initialization proceeds even when the memory mapping fails.

@aisk
Copy link
Contributor

Hi, I think a related issue and a news entry file are needed for this PR. Please read the Dev Guide (especiallyhttps://devguide.python.org/getting-started/pull-request-lifecycle/) to see what is required when creating a PR.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The change LGTM, but I agree with@aisk: it would be nice to document the fix in a NEWS entry.

@vstinnervstinner added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJan 22, 2026
@stratakisstratakis changed the titleFix mmap failure check in perf_jit_trampoline.cgh-144194: Fix mmap failure check in perf_jit_trampoline.cJan 23, 2026
@StanFromIreland
Copy link
Member

You need to update your branch to fix the CI, it is incompatible.

mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The currentcheck never detects mmap failures, so jitdump initialization proceedseven when the memory mapping fails.
@vstinner
Copy link
Member

Thanks for fixing the Linter issue ;-)

@vstinnervstinner merged commit8fe8a94 intopython:mainJan 28, 2026
47 checks passed
@miss-islington-app
Copy link

Thanks@stratakis for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 28, 2026
…honGH-143713)mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The currentcheck never detects mmap failures, so jitdump initialization proceedseven when the memory mapping fails.(cherry picked from commit8fe8a94)Co-authored-by: stratakis <cstratak@redhat.com>
@miss-islington-app
Copy link

Sorry,@stratakis and@vstinner, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 8fe8a94a7c050bc16cac9ec300f89c0f389f9a44 3.13

@bedevere-app
Copy link

GH-144301 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJan 28, 2026
@bedevere-app
Copy link

GH-144304 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 28, 2026
@vstinner
Copy link
Member

PR merged, thanks for the fix.

vstinner pushed a commit that referenced this pull requestJan 28, 2026
…-143713) (#144301)gh-144194: Fix mmap failure check in perf_jit_trampoline.c (GH-143713)mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The currentcheck never detects mmap failures, so jitdump initialization proceedseven when the memory mapping fails.(cherry picked from commit8fe8a94)Co-authored-by: stratakis <cstratak@redhat.com>
vstinner added a commit that referenced this pull requestJan 28, 2026
…43713) (#144304)gh-144194: Fix mmap failure check in perf_jit_trampoline.c (#143713)mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The currentcheck never detects mmap failures, so jitdump initialization proceedseven when the memory mapping fails.(cherry picked from commit8fe8a94)Co-authored-by: stratakis <cstratak@redhat.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

Assignees

@vstinnervstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stratakis@aisk@StanFromIreland@vstinner
[8]ページ先頭
©2009-2026 Movatter.jp