Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-143672: convert the struct module to AC#143673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| See help(struct) for more on format strings. | ||
| Return a new Struct object which writes and reads binary data according | ||
| to the format string. See help(struct) for more on format strings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what is the reason for newline -> double space change? I was not aware that this is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In some docstrings "See help(struct) for more on format strings." was separated to a new paragraph. In some - no. Looks as a waste of space, especially in help(struct) output.
Modules/_struct.c Outdated
| / | ||
| *args: array | ||
| Pack args to the writtable buffer according to the format self. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Packargstothewrittablebufferaccordingtotheformatself. | |
| Packargstothewrittablebufferaccordingtothestruct'sformatstring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Too long. Beware@permit_long_summary.
Modules/_struct.c Outdated
| strings."); | ||
| *args: array | ||
| Return a bytes object with args, packed according the format self. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Returnabytesobjectwithargs,packedaccordingtheformatself. | |
| Returnabytesobjectwithargs,packedaccordingthestruct'sformatstring. |
skirpichev commentedJan 11, 2026
BTW, I'm not attached to docstrings. IMO, they aren't good and I tried to improve that. But I can just revert that stuff and keep old doctsrings almost literally (summary line is required, though). |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, I have not noticed this PR and created an alternative PR#143857.
There are some differences between two PRs, and I had reasons for all changes. We can now gradually convert your PR into my PR by applying one change at a time or just take my PR.
See the difference between the PRs:https://github.com/skirpichev/cpython/pull/14/changes .
| Struct.pack_into as s_pack_into | ||
| buffer: Py_buffer | ||
| offset: Py_ssize_t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is a subtle behavior difference here (IndexError vs OverflowError). I leave this for other issue.
Modules/_struct.c Outdated
| buffer: Py_buffer | ||
| offset: Py_ssize_t | ||
| / | ||
| *args: array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I prever to use more specific namevalues.
Modules/_struct.c Outdated
| /*[clinic input] | ||
| Struct.pack_into as s_pack_into | ||
| buffer: Py_buffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The buffer must be writeable.
| offset. Note that the offset is a required argument. See\n\ | ||
| help(struct) for more on format strings."); | ||
| /*[clinic input] | ||
| Struct.pack_into as s_pack_into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No need to rename it.
Uh oh!
There was an error while loading.Please reload this page.