Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-143638: Forbid cuncurrent use of the Pickler and Unpickler objects in C implementation#143664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJan 10, 2026•
edited by bedevere-appbot
Loading

Previously, this could cause crash or data corruption, now concurrent calls of methods of the same object raise RuntimeError.

…bjects in C implementationPreviously, this could cause crash or data corruption, now concurrent callsof methods of the same object raise RuntimeError.
@serhiy-storchaka
Copy link
MemberAuthor

I am not sure that this all is right. There may be legitimate case to accessmemo infind_class() orpersistent_id(). So, I remove guards from memo related code for now, until we get user reports. It does not release the GIL or call user code, so it may be difficult to create a reproducer for potential issues, if they even exist.

@serhiy-storchakaserhiy-storchaka merged commitd1282ef intopython:mainJan 11, 2026
46 checks passed
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@serhiy-storchakaserhiy-storchaka deleted the pickle-concurrent branchJanuary 11, 2026 12:01
@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker d1282efb2b847bf9274d78c5f15ea00499b2c894 3.14

@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker d1282efb2b847bf9274d78c5f15ea00499b2c894 3.13

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestJan 11, 2026
…ckler objects in C implementation (pythonGH-143664)Previously, this could cause crash or data corruption, now concurrent callsof methods of the same object raise RuntimeError.(cherry picked from commitd1282ef)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestJan 11, 2026
…ckler objects in C implementation (pythonGH-143664)Previously, this could cause crash or data corruption, now concurrent callsof methods of the same object raise RuntimeError.(cherry picked from commitd1282ef)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-143686 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJan 11, 2026
@bedevere-app
Copy link

GH-143687 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 11, 2026
serhiy-storchaka added a commit that referenced this pull requestJan 11, 2026
…objects in C implementation (GH-143664) (GH-143687)Previously, this could cause crash or data corruption, now concurrent callsof methods of the same object raise RuntimeError.(cherry picked from commitd1282ef)
serhiy-storchaka added a commit that referenced this pull requestJan 11, 2026
…objects in C implementation (GH-143664) (GH-143686)Previously, this could cause crash or data corruption, now concurrent callsof methods of the same object raise RuntimeError.(cherry picked from commitd1282ef)
reidenong pushed a commit to reidenong/cpython that referenced this pull requestJan 12, 2026
…bjects in C implementation (pythonGH-143664)Previously, this could cause crash or data corruption, now concurrent callsof methods of the same object raise RuntimeError.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rhettingerrhettingerrhettinger approved these changes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka@rhettinger
[8]ページ先頭
©2009-2026 Movatter.jp