Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-143602: Fix duplicate buffer exports in io.BytesIO.write#143629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 3 commits intopython:mainfromsuperboy-zjc:issue-143602
Jan 15, 2026

Conversation

@superboy-zjc
Copy link
Contributor

@superboy-zjcsuperboy-zjc commentedJan 9, 2026•
edited by bedevere-appbot
Loading

Fix a inconsistency issue in io.BytesIO.write() where the buffer was exported twice, which could lead to unexpected data overwrites and position drift when the buffer changes between exports.

Fix a inconsistency issue in io.BytesIO.write() where the buffer was exported twice, which could lead to unexpected data overwrites and position drift when the buffer changes between exports.
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. The NEWS entry can be enhanced, but I cannot propose a better description.

@vstinnervstinner merged commitc461aa9 intopython:mainJan 15, 2026
50 checks passed
@vstinnervstinner added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJan 15, 2026
@miss-islington-app
Copy link

Thanks@superboy-zjc for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@superboy-zjc for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry,@superboy-zjc and@vstinner, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker c461aa99e2fabbaf5859c0a8a93e08306ee8115d 3.13

@miss-islington-app
Copy link

Sorry,@superboy-zjc and@vstinner, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker c461aa99e2fabbaf5859c0a8a93e08306ee8115d 3.14

@bedevere-app
Copy link

GH-143872 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJan 15, 2026
@vstinner
Copy link
Member

I backported the change to 3.14:#143872.

@vstinnervstinner removed the needs backport to 3.13bugs and security fixes labelJan 15, 2026
@vstinner
Copy link
Member

Merged, thanks for your contribution@superboy-zjc.

vstinner pushed a commit to vstinner/cpython that referenced this pull requestJan 15, 2026
…thon#143629)Fix an inconsistency issue in io.BytesIO.write() where the buffer was exportedtwice, which could lead to unexpected data overwrites and position drift whenthe buffer changes between exports.(cherry picked from commitc461aa9)
@serhiy-storchaka
Copy link
Member

LGTM. 👍

vstinner added a commit that referenced this pull requestJan 15, 2026
…143629) (#143872)gh-143602: Fix duplicate buffer exports in io.BytesIO.write (#143629)Fix an inconsistency issue in io.BytesIO.write() where the buffer was exportedtwice, which could lead to unexpected data overwrites and position drift whenthe buffer changes between exports.(cherry picked from commitc461aa9)Co-authored-by: zhong <60600792+superboy-zjc@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 macOS 3.14 (tier-2) has failed when building commit1241432.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1772/builds/811) and take a look at the build logs.
  4. Check if the failure is related to this commit (1241432) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1772/builds/811

Failed tests:

  • test_urllib2net

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 11, done.remote:Counting objects:  25% (1/4)remote:Counting objects:  50% (2/4)remote:Counting objects:  75% (3/4)remote:Counting objects: 100% (4/4)remote:Counting objects: 100% (4/4), done.remote:Compressing objects:  33% (1/3)remote:Compressing objects:  66% (2/3)remote:Compressing objects: 100% (3/3)remote:Compressing objects: 100% (3/3), done.remote:Total 11 (delta 1), reused 1 (delta 1), pack-reused 7 (from 2)From https://github.com/python/cpython * branch                    3.14       -> FETCH_HEADNote:switching to '1241432150f6342e3d38c5a80a19c8c157a4ebe8'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 1241432150f [3.14] gh-143602: Fix duplicate buffer exports in io.BytesIO.write (#143629) (#143872)Switched to and reset branch '3.14'make:*** [buildbottest] Error 2

vstinner added a commit that referenced this pull requestJan 16, 2026
…143629) (#143872) (#143878)[3.14]gh-143602: Fix duplicate buffer exports in io.BytesIO.write (#143629) (#143872)gh-143602: Fix duplicate buffer exports in io.BytesIO.write (#143629)Fix an inconsistency issue in io.BytesIO.write() where the buffer was exportedtwice, which could lead to unexpected data overwrites and position drift whenthe buffer changes between exports.(cherry picked from commitc461aa9)(cherry picked from commit1241432)Co-authored-by: zhong <60600792+superboy-zjc@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

@vstinnervstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@superboy-zjc@vstinner@serhiy-storchaka@bedevere-bot
[8]ページ先頭
©2009-2026 Movatter.jp