Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-143547: Fix PyErr_FormatUnraisable() fallback#143557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hold a strong reference to 'hook' while calling the defaultunraisable took to log hook failure.Fix test_sys.UnraisableHookTest: use the right decorator function todisable colors. Previously, tests were always skipped.
Uh oh!
There was an error while loading.Please reload this page.
ZeroIntensity left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks user-facing, so I think it would be a good idea to add a news entry, but I'll leave the decision up to you. The rest of the PR looks good to me.
vstinner commentedJan 8, 2026
Ok, I added a NEWS entry. |
39a2bcf intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry,@vstinner, I could not cleanly backport this to |
Sorry,@vstinner, I could not cleanly backport this to |
GH-143603 is a backport of this pull request to the3.14 branch. |
Hold a strong reference to 'hook' while calling the defaultunraisable took to log hook failure.(cherry picked from commit39a2bcf)
…GH-143557) (pythonGH-143603)pythongh-143547: Fix PyErr_FormatUnraisable() fallback (pythonGH-143557)Hold a strong reference to 'hook' while calling the defaultunraisable took to log hook failure.(cherry picked from commit1d0baf1)Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commit39a2bcf)
…H-143603) (#143612)[3.14]gh-143547: Fix PyErr_FormatUnraisable() fallback (GH-143557) (GH-143603)gh-143547: Fix PyErr_FormatUnraisable() fallback (GH-143557)Hold a strong reference to 'hook' while calling the defaultunraisable took to log hook failure.(cherry picked from commit1d0baf1)(cherry picked from commit39a2bcf)Co-authored-by: Victor Stinner <vstinner@python.org>
Hold a strong reference to 'hook' while calling the defaultunraisable took to log hook failure.Fix test_sys.UnraisableHookTest: use the right decorator function todisable colors. Previously, tests were always skipped.
Uh oh!
There was an error while loading.Please reload this page.
Hold a strong reference to 'hook' while calling the default unraisable took to log hook failure.
Fix test_sys.UnraisableHookTest: use the right decorator function to disable colors. Previously, tests were always skipped.
sys.unraisablehookfails and falls back to default logger #143547