Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-143553: Add support for parametrized resources in regrtests#143554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJan 8, 2026•
edited by github-actionsbot
Loading

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

I'm not really convinced that test_xpickle justify adding this complexity (-u xpickle would be enough), but I'm not strongly against this feature.

@serhiy-storchaka
Copy link
MemberAuthor

-u xpickle enables it for all available Python versions. On my computer it will run about half a hour. With-u xpickle=... I can test only specified version. Previously, I just edited the source code, but this was inconvenient and there was risk to commit temporary modified code.

#65784 is other issue where I need to edit the source codes to run tests with special configuration.

@serhiy-storchakaserhiy-storchaka merged commitc07e5ec intopython:mainJan 8, 2026
55 checks passed
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 8, 2026
…ythonGH-143554)For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.(cherry picked from commitc07e5ec)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchakaserhiy-storchaka deleted the test-resources-values branchJanuary 8, 2026 11:51
@bedevere-app
Copy link

GH-143555 is a backport of this pull request to the3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 8, 2026
…ythonGH-143554)For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.(cherry picked from commitc07e5ec)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJan 8, 2026
@bedevere-app
Copy link

GH-143556 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 8, 2026
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 macOS 3.x (tier-2) has failed when building commitc07e5ec.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/725/builds/12487) and take a look at the build logs.
  4. Check if the failure is related to this commit (c07e5ec) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/725/builds/12487

Failed tests:

  • test_urllib2net

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 21, done.remote:Counting objects:   4% (1/21)remote:Counting objects:   9% (2/21)remote:Counting objects:  14% (3/21)remote:Counting objects:  19% (4/21)remote:Counting objects:  23% (5/21)remote:Counting objects:  28% (6/21)remote:Counting objects:  33% (7/21)remote:Counting objects:  38% (8/21)remote:Counting objects:  42% (9/21)remote:Counting objects:  47% (10/21)remote:Counting objects:  52% (11/21)remote:Counting objects:  57% (12/21)remote:Counting objects:  61% (13/21)remote:Counting objects:  66% (14/21)remote:Counting objects:  71% (15/21)remote:Counting objects:  76% (16/21)remote:Counting objects:  80% (17/21)remote:Counting objects:  85% (18/21)remote:Counting objects:  90% (19/21)remote:Counting objects:  95% (20/21)remote:Counting objects: 100% (21/21)remote:Counting objects: 100% (21/21), done.remote:Compressing objects:  16% (1/6)remote:Compressing objects:  33% (2/6)remote:Compressing objects:  50% (3/6)remote:Compressing objects:  66% (4/6)remote:Compressing objects:  83% (5/6)remote:Compressing objects: 100% (6/6)remote:Compressing objects: 100% (6/6), done.remote:Total 21 (delta 15), reused 20 (delta 15), pack-reused 0 (from 0)From https://github.com/python/cpython * branch                    main       -> FETCH_HEADNote:switching to 'c07e5ec0a9e5843fc39dec6aa94172faf6354858'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at c07e5ec0a9e gh-143553: Add support for parametrized resources in regrtests (GH-143554)Switched to and reset branch 'main'make:*** [buildbottest] Error 2

serhiy-storchaka added a commit that referenced this pull requestJan 8, 2026
…GH-143554) (GH-143555)For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.(cherry picked from commitc07e5ec)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestJan 8, 2026
…GH-143554) (GH-143556)For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.(cherry picked from commitc07e5ec)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
reidenong pushed a commit to reidenong/cpython that referenced this pull requestJan 12, 2026
…ythonGH-143554)For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

testsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka@bedevere-bot@vstinner
[8]ページ先頭
©2009-2026 Movatter.jp