Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-143517: Fix an edge case in rewriting stringified starred annotations#143518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-143517: Fix an edge case in rewriting stringified starred annotations#143518
Uh oh!
There was an error while loading.Please reload this page.
Conversation
johnslavik commentedJan 7, 2026
(Ignore the name of856f612, it's misleading) |
*
sobolevn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems simple enough :)
JelleZijlstra left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure why anyone would do this, but we acceptx: " int" and parse it intoint, so I guess we should accept this too.
6c9f7b4 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@johnslavik for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…notations (pythonGH-143518)(cherry picked from commit6c9f7b4)Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
GH-143540 is a backport of this pull request to the3.14 branch. |
johnslavik commentedJan 8, 2026
I was mainly thinking that some automated code generation only could run into that. |
Uh oh!
There was an error while loading.Please reload this page.
get_annotations(..., eval_str=True)throwsSyntaxErrorif stringified starred annotation starts with one or more spaces #143517