Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-143474: Add os.RWF_ATOMIC constant#143475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ZeroIntensity merged 1 commit intopython:mainfromclaydugo:gh-143474-rwf-atomic
Jan 6, 2026

Conversation

@claydugo
Copy link
Contributor

@claydugoclaydugo commentedJan 6, 2026
edited
Loading

@python-cla-bot
Copy link

python-cla-botbot commentedJan 6, 2026
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

- RWF_SYNC
- RWF_APPEND
- RWF_DONTCACHE
- RWF_ATOMIC

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(i work with clay and he has been keeping me updated on the discussion thx all)

May I suggest we follow the order from
https://github.com/torvalds/linux/blob/7f98ab9da046865d57c102fd3ca9669a29845f67/include/uapi/linux/fs.h#L429

these low level flags are pretty tricky to get right, and to validate, keeping the order the "same" helps triple check things.

Excited that this is getting a revival!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can consider that for a follow-up PR. I think it's important to keep the blame intact here, so when Linux goes and adds new flags, we can quickly look up the precedent for adding them.

hmaarrfk reacted with thumbs up emoji
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@ZeroIntensity
Copy link
Member

I'm going to merge this. It's intentional that this doesn't have a "What's New" entry, since one wasn't added forRWF_DONTCACHE either (#139090). If anyone disagrees, please submit a follow-up PR containing an entry for bothRWF_DONTCACHE andRFC_ATOMIC and tag me for a review.

claydugo reacted with heart emoji

@ZeroIntensityZeroIntensity merged commitd745b60 intopython:mainJan 6, 2026
87 of 89 checks passed
@hmaarrfk
Copy link

Very cool. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

+1 more reviewer

@hmaarrfkhmaarrfkhmaarrfk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@claydugo@ZeroIntensity@hmaarrfk

[8]ページ先頭

©2009-2026 Movatter.jp