Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-143474: Add os.RWF_ATOMIC constant#143475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
python-cla-botbot commentedJan 6, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
05b03ad to90be11bCompare| - RWF_SYNC | ||
| - RWF_APPEND | ||
| - RWF_DONTCACHE | ||
| - RWF_ATOMIC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(i work with clay and he has been keeping me updated on the discussion thx all)
May I suggest we follow the order from
https://github.com/torvalds/linux/blob/7f98ab9da046865d57c102fd3ca9669a29845f67/include/uapi/linux/fs.h#L429
these low level flags are pretty tricky to get right, and to validate, keeping the order the "same" helps triple check things.
Excited that this is getting a revival!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We can consider that for a follow-up PR. I think it's important to keep the blame intact here, so when Linux goes and adds new flags, we can quickly look up the precedent for adding them.
ZeroIntensity left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
ZeroIntensity commentedJan 6, 2026
I'm going to merge this. It's intentional that this doesn't have a "What's New" entry, since one wasn't added for |
d745b60 intopython:mainUh oh!
There was an error while loading.Please reload this page.
hmaarrfk commentedJan 6, 2026
Very cool. Thanks! |
Uh oh!
There was an error while loading.Please reload this page.
os.RWF_ATOMICconstant #143474📚 Documentation preview 📚:https://cpython-previews--143475.org.readthedocs.build/