Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-143241: Fix infinite loop in zoneinfo._common.load_data#143243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 10 commits intopython:mainfromfatihhcelik:fix-zoneinfo-infinite-loop
Dec 28, 2025

Conversation

@fatihhcelik
Copy link
Contributor

@fatihhcelikfatihhcelik commentedDec 28, 2025•
edited by bedevere-appbot
Loading

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@python-cla-bot
Copy link

python-cla-botbot commentedDec 28, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

Please add a NEWS entry, users will be glad to know that that bug was fixed.

I would not call it a DoS.

fatihhcelik reacted with rocket emoji
@fatihhcelikfatihhcelik changed the titlegh-143241: Fix infinite loop DoS in zoneinfo._common.load_datagh-143241: Fix infinite loop in zoneinfo._common.load_dataDec 28, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
blurb-itbotand others added3 commitsDecember 28, 2025 13:49
Remove unnecessary tz_bytes variable.Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

I'm going to wait for the CI to be green and then I'll merge.

fatihhcelik reacted with rocket emoji

@picnixzpicnixz merged commit3ca1f2a intopython:mainDec 28, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks@fatihhcelik for the PR, and@picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 28, 2025
…ythonGH-143243)Correctly reject truncated TZif files in `ZoneInfo.from_file`.---------(cherry picked from commit3ca1f2a)Co-authored-by: Fatih Çelik <fcelik.ft@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 28, 2025
…ythonGH-143243)Correctly reject truncated TZif files in `ZoneInfo.from_file`.---------(cherry picked from commit3ca1f2a)Co-authored-by: Fatih Çelik <fcelik.ft@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

GH-143251 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelDec 28, 2025
@bedevere-app
Copy link

GH-143252 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 28, 2025
picnixz added a commit that referenced this pull requestDec 28, 2025
…H-143243) (#143252)gh-143241: Fix infinite loop in `zoneinfo._common.load_data` (GH-143243)Correctly reject truncated TZif files in `ZoneInfo.from_file`.---------(cherry picked from commit3ca1f2a)Co-authored-by: Fatih Çelik <fcelik.ft@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull requestDec 28, 2025
…H-143243) (#143251)gh-143241: Fix infinite loop in `zoneinfo._common.load_data` (GH-143243)Correctly reject truncated TZif files in `ZoneInfo.from_file`.---------(cherry picked from commit3ca1f2a)Co-authored-by: Fatih Çelik <fcelik.ft@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@picnixzpicnixzpicnixz approved these changes

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fatihhcelik@picnixz@serhiy-storchaka
[8]ページ先頭
©2009-2026 Movatter.jp