Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-63016: Skip some mmap tests on FreeBSD#143230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 2 commits intopython:mainfromaisk:skip-mmap-bsd
Dec 28, 2025
Merged

Conversation

@aisk
Copy link
Contributor

@aiskaisk commentedDec 27, 2025
edited by bedevere-appbot
Loading

@aisk
Copy link
ContributorAuthor

!buildbot freebsd

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@aisk for commit5151a11 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143230%2Fmerge

The command will test the builders whose names match following regular expression:freebsd

The builders matched are:

  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR
  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR

@aiskaisk requested a review frompicnixzDecember 27, 2025 17:46
@aisk
Copy link
ContributorAuthor

@picnixz Hi, I'm not sure why FreeBSD doesn't support this usage, but I think we can just skip this test as a fix and assume that FreeBSD simply doesn't supportm.flush(0, PAGESIZE, flags=mmap.MS_ASYNC | mmap.MS_INVALIDATE)?

@picnixz
Copy link
Member

I didn't look at the buildbot traceback but if the combination is not supported, I'd prefer checking for an exception being raised.

@aisk
Copy link
ContributorAuthor

I have a FreeBSD VM and this is the traceback I got:

$ ./python -m test test_mmapUsing random seed: 11456396830:00:00 load avg: 0.85 Run 1 test sequentially in a single process0:00:00 load avg: 0.85 [1/1] test_mmaptest test_mmap failed -- Traceback (most recent call last):  File "/usr/home/asaka/cpython/Lib/test/test_mmap.py", line 1176, in test_flush_parameters    m.flush(0, PAGESIZE, flags=mmap.MS_ASYNC | mmap.MS_INVALIDATE)    ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^OSError: [Errno 22] Invalid argument0:00:00 load avg: 0.85 [1/1/1] test_mmap failed (1 error)== Tests result: FAILURE ==1 test failed:    test_mmapTotal duration: 120 msTotal tests: run=53 skipped=13Total test files: run=1/1 failed=1Result: FAILURE

I'm not very familiar with BSD, but I will try to just check the error on FreeBSD. If this is not acceptable, I'll dig into it tomorrow.

@picnixz
Copy link
Member

picnixz commentedDec 27, 2025
edited
Loading

I think catching OSError would be sufficient then. What matters is that we don't crash.

@aisk
Copy link
ContributorAuthor

!buildbot bsd

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@aisk for commitba674d5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143230%2Fmerge

The command will test the builders whose names match following regular expression:bsd

The builders matched are:

  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR
  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR

@picnixz
Copy link
Member

I'll wait for the bots to complete and then I'll merge this.

@picnixzpicnixz merged commitc3bfe5d intopython:mainDec 28, 2025
52 checks passed
@aiskaisk deleted the skip-mmap-bsd branchDecember 29, 2025 01:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aisk@bedevere-bot@picnixz

[8]ページ先頭

©2009-2026 Movatter.jp