Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-143183: Rewind stop tracing to previous target#143187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commentedDec 26, 2025•
edited
Loading

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@tomasr8tomasr8 self-requested a reviewDecember 28, 2025 19:03
Copy link
Member

@tomasr8tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some nits, otherwise looks good!

// gh-143183: It's important we rewind to the last known proper target.
// The current target might be garbage as stop tracing usually indicates
// we are in something that we can't trace.
goto unsupported;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it worth to add aDPRINTF() here? All the othergoto unsupported have it

Fidget-Spinner reacted with thumbs up emoji
@Fidget-SpinnerFidget-Spinner merged commitdaa9aa4 intopython:mainDec 28, 2025
64 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 left review comments

@tomasr8tomasr8tomasr8 approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: Assertion failure instopiteration_error

3 participants

@Fidget-Spinner@tomasr8@kumaraditya303
[8]ページ先頭
©2009-2026 Movatter.jp