Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-120321: Avoid-Wunreachable-code warning on Clang#143022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
colesbury commentedDec 20, 2025
I hate this, but I hate the other options even more. |
mpage left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We'll end up seeing the warning if clang's analysis gets more capable, right? I guess that's still better than disabling warnings around the block in the default build.
Test failure looks unrelated.
colesbury commentedDec 20, 2025
I think it's more a matter of convention than capability. Clang can easily optimize through all these things and this warning is only enabled inoptimized builds (not debug builds). Clang doesn't warn for things like: But it warns for: But not for: But you can't put that expression in a macro: |
7607712 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.