Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
[3.13] gh-142560: prevent use-after-free in search-like methods by exporting buffer in bytearray (GH-142938)#142986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cmaloney wants to merge1 commit intopython:3.13Choose a base branch
base:3.13
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+110 −41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… by exporting buffer in bytearray (pythonGH-142938)(cherry picked from commit220f0b1)Co-authored-by: wangxiaolei <fatelei@gmail.com>
This was referencedDec 19, 2025
Member
vstinner commentedDec 19, 2025
Sadly, the build fails :-( |
ContributorAuthor
cmaloney commentedDec 19, 2025
Will work on resolving in a bit; free threaded build worked for me... i need to improve my local tools for doing multiple builde |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This backport is more intricate as free threading / locking / critical sections was only added to
bytearrayin 3.14; this makesbytearraysafer in 3.13 (The methods that use_bytearray_with_buffershould now be thread safe as it does the critical section), but I did not make all the methods thread safe that are thread safe in 3.14 (Without the clinic annotation doing so well is a lot more difficult)(cherry picked from commit220f0b1)
bytearraysearch methods via re-entrant__index__#142560