Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-140550: Update xxlimited with 3.15 limited API & PEP 697#142827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
encukou wants to merge13 commits intopython:main
base:main
Choose a base branch
Loading
fromencukou:xxlimited-3.15
Draft
Changes from1 commit
Commits
Show all changes
13 commits
Select commitHold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Style
  • Loading branch information
@encukou
encukou committedDec 17, 2025
commitff0f3008410c55be467d780d5a39b27df83e5817

Some comments aren't visible on the classic Files Changed page.

3 changes: 2 additions & 1 deletionModules/xxlimited.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,7 +160,8 @@ Xxo_get_data(PyObject *self)
// This is the implementation of Xxo.__new__; it takes arbitrary positional
// and keyword arguments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't understand "it takes arbitrary positional and keyword arguments" since the error message below is "Xxo.__new__() takes no arguments".

encukou reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thetp_new calling convention takes args&kwargs, so we need to check.
I agree the comment was misleading. Also the situation should be clear without the comment, so I removed it.

static PyObject *
Xxo_new(PyTypeObject *type, PyObject *args, PyObject *kwargs) {
Xxo_new(PyTypeObject *type, PyObject *args, PyObject *kwargs)
{
// Validate that we did not get any arguments.
if ((args != NULL && PyObject_Length(args))
|| (kwargs != NULL && PyObject_Length(kwargs)))
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp