NotificationsYou must be signed in to change notification settings
Fork33.4k
Star69.8k

bpo-37151: remove _PyCFunction_FastCallDict#14269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

methane merged 1 commit intopython:masterfromjdemeyer:remove_PyCFunction_FastCallDict

Jun 20, 2019

Merged

bpo-37151: remove _PyCFunction_FastCallDict#14269

methane merged 1 commit intopython:masterfromjdemeyer:remove_PyCFunction_FastCallDict

Jun 20, 2019

Conversation

Copy link

Contributor

jdemeyer commentedJun 20, 2019•
edited by bedevere-bot
Loading

The function_PyCFunction_FastCallDict is currently used in exactly one place, namely in the profiling branch ofdo_call_core. Its use can easily be replaced by_PyObject_FastCallDict and then we can remove_PyCFunction_FastCallDict.

CC@encukou @methane

https://bugs.python.org/issue37151

bpo-37151: remove _PyCFunction_FastCallDict

d7237af

the-knights-who-say-ni added the CLA signed label

Jun 20, 2019

bedevere-bot added the awaiting review label

Jun 20, 2019

methane added the skip news label

Jun 20, 2019

methane merged commit7e1a9aa intopython:master

Jun 20, 2019

bedevere-bot removed the awaiting review label

Jun 20, 2019

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Jun 21, 2019

Merge branch 'master' into fix-issue24255

7bf6445

* master: (599 commits)  Docs: Improved phrasing (pythonGH-14069)  Remove redundant if check from optional argument function in argparse. (pythonGH-8766)  bpo-37289: Add a test for if with ifexpr in the peephole optimiser to detect regressions (pythonGH-14127)  Update What's New in Python 3.9 (pythonGH-14253)  bpo-36511: Improve ARM32 buildbot scripts (pythonGH-14251)  bpo-37151: remove _PyCFunction_FastCallDict (pythonGH-14269)  Fix typo, 'widger' -> 'widget', in idlelib/tree.py (pythonGH-14263)  Fix bpo number in News file. (pythonGH-14260)  bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (pythonGH-14241)  Update What's New in Python 3.8 (pythonGH-14239)  bpo-36710: Use tstate in pylifecycle.c (pythonGH-14249)  Add missing single quote in io.TextIOWrapper.reconfigure documentation (pythonGH-14246)  bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot (pythonGH-13454)  bpo-37333: Ensure IncludeTkinter has a value (pythonGH-14240)  bpo-37331: Clarify format of socket handler messages in the documentation. (pythonGH-14234)  bpo-37258: Not a bug, but added a unit test and updated documentation. (pythonGH-14229)  bpo-36710: Remove PyImport_Cleanup() function (pythonGH-14221)  Fix name of '\0'. (pythonGH-14222)  bpo-36710: Add tstate parameter in import.c (pythonGH-14218)  Document typing.ForwardRef (pythonGH-14216)  ...