Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-134584: Remove custom float decref ops#142576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-134584: Remove custom float decref ops#142576
Uh oh!
There was an error while loading.Please reload this page.
Conversation
markshannon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you leave the STACK_SIZE macro unchanged to avoid confusion and changehttps://github.com/python/cpython/pull/142576/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2L199
instead.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
markshannon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good now. Thanks.
markshannon commentedDec 15, 2025
One thing to note for the future: We are losing the ability to reuse one of the operands if its refcount was one. A possible future optimization is to not only track which references are deferred, but which are the only reference to the object. We can then avoid the allocation & deallocation that occurs in |
0ac4e6c intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.