Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-139862: Fix direct instantiation ofHelpFormatter#142384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowskisavannahostrowski commentedDec 7, 2025•
edited by bedevere-appbot
Loading

Based on#142274 (comment), the issue here is thatformat_help() eventually accessesself._theme but_theme was never set since_set_color() is no longer called in__init__. I think we can initialize_theme to a safe default (no color) so that direct instantiation works but the parser can still override it afterward.

@savannahostrowski
Copy link
MemberAuthor

@hamdanal Mind also taking a look at this and making sure everything is fixed on your end?

Copy link
Contributor

@hamdanalhamdanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This fixes the problem. Thank you.

savannahostrowski reacted with heart emoji
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Worth adding a regression test?

savannahostrowski reacted with thumbs up emoji
@savannahostrowskisavannahostrowskienabled auto-merge (squash)December 7, 2025 20:36
@savannahostrowskisavannahostrowski merged commitdc9f238 intopython:mainDec 7, 2025
44 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

+1 more reviewer

@hamdanalhamdanalhamdanal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@savannahostrowski@hugovk@hamdanal
[8]ページ先頭
©2009-2026 Movatter.jp