Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-129483: MakeTestLocalTimeDisambiguation's time format locale independent#142193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pganssle merged 4 commits intopython:mainfromgkirchou:gh-129483
Dec 4, 2025

Conversation

@gkirchou
Copy link
Contributor

@gkirchougkirchou commentedDec 2, 2025•
edited by bedevere-appbot
Loading

Test with:

./configure --enable-optimizations --with-ltomake -s -j $(nproc);

@bedevere-app

This comment was marked as resolved.

Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IMO making the tests locale independent would be a better solution than this (i.e. just replace%c with our desired order).

@bedevere-app

This comment was marked as resolved.

@gkirchougkirchou changed the titlegh-129483: Force TestLocalTimeDisambiguation to run on LC_ALL=Cgh-129483: Clarify TestLocalTimeDisambiguation's time formatDec 3, 2025
@gkirchou
Copy link
ContributorAuthor

IMO making the tests locale independent would be a better solution than this (i.e. just replace%c with our desired order).

Addressed

@StanFromIrelandStanFromIreland changed the titlegh-129483: Clarify TestLocalTimeDisambiguation's time formatgh-129483: MakeTestLocalTimeDisambiguation's time format locale independentDec 3, 2025
Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

@python-cla-bot
Copy link

python-cla-botbot commentedDec 3, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@pgansslepganssle merged commit8392095 intopython:mainDec 4, 2025
44 checks passed
@pganssle
Copy link
Member

This is failing in 3.13, right? So we should backport it? Anyone know how far back it is causing issues?

@vstinnervstinner added the needs backport to 3.14bugs and security fixes labelDec 4, 2025
@miss-islington-app
Copy link

Thanks@gkirchou for the PR, and@pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 4, 2025
…ale independent (pythonGH-142193)* Change to update %c to the exact time format.---------(cherry picked from commit8392095)Co-authored-by: Kir Chou <148194051+gkirchou@users.noreply.github.com>Co-authored-by: Kir Chou <note351@hotmail.com>
@bedevere-app
Copy link

GH-142258 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelDec 4, 2025
@vstinnervstinner added the needs backport to 3.13bugs and security fixes labelDec 4, 2025
@miss-islington-app
Copy link

Thanks@gkirchou for the PR, and@pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 4, 2025
…ale independent (pythonGH-142193)* Change to update %c to the exact time format.---------(cherry picked from commit8392095)Co-authored-by: Kir Chou <148194051+gkirchou@users.noreply.github.com>Co-authored-by: Kir Chou <note351@hotmail.com>
@bedevere-app
Copy link

GH-142259 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 4, 2025
@vstinner
Copy link
Member

This is failing in 3.13, right? So we should backport it? Anyone know how far back it is causing issues?

Right, the issue was reported on Python 3.13.1. We should backport the change to 3.13 and 3.14 branches. Other branchesno longer accept bugfixes.

vstinner pushed a commit that referenced this pull requestDec 4, 2025
…cale independent (GH-142193) (#142259)gh-129483: Make `TestLocalTimeDisambiguation`'s time format locale independent (GH-142193)* Change to update %c to the exact time format.---------(cherry picked from commit8392095)Co-authored-by: Kir Chou <148194051+gkirchou@users.noreply.github.com>Co-authored-by: Kir Chou <note351@hotmail.com>
vstinner pushed a commit that referenced this pull requestDec 4, 2025
…cale independent (GH-142193) (#142258)gh-129483: Make `TestLocalTimeDisambiguation`'s time format locale independent (GH-142193)* Change to update %c to the exact time format.---------(cherry picked from commit8392095)Co-authored-by: Kir Chou <148194051+gkirchou@users.noreply.github.com>Co-authored-by: Kir Chou <note351@hotmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Stable LTO + PGO 3.13 (tier-3) has failed when building commite68066e.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1633/builds/552) and take a look at the build logs.
  4. Check if the failure is related to this commit (e68066e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1633/builds/552

Summary of the results of the build (if available):

Click to see traceback logs
remote:Enumerating objects: 5, done.remote:Counting objects:  20% (1/5)remote:Counting objects:  40% (2/5)remote:Counting objects:  60% (3/5)remote:Counting objects:  80% (4/5)remote:Counting objects: 100% (5/5)remote:Counting objects: 100% (5/5), done.remote:Total 5 (delta 4), reused 4 (delta 4), pack-reused 0 (from 0)From https://github.com/python/cpython * branch                    3.13       -> FETCH_HEADNote:switching to 'e68066eb0957f5cad8e8959ea8f3f681bfda0994'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at e68066eb095 [3.13] gh-129483: Make `TestLocalTimeDisambiguation`'s time format locale independent (GH-142193) (#142259)Switched to and reset branch '3.13'find:‘build’: No such file or directoryfind:‘build’: No such file or directoryfind:‘build’: No such file or directoryfind:‘build’: No such file or directorymake[2]:[Makefile:3127: clean-retain-profile] Error 1 (ignored)In function ‘hashtable_key_from_2_strings’,    inlinedfrom ‘_extensions_cache_find_unlocked’ at Python/import.c:1264:17:Python/import.c:1177:5: warning: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] 1177 |     strncpy(key, str1_data, str1_len);|^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Python/import.c:1163:27: note: length computed here 1163 |     Py_ssize_t str1_len = strlen(str1_data);|^~~~~~~~~~~~~~~~~test_denial_of_service_prevented_int_to_str (test.test_int.IntStrDigitLimitsTests.test_denial_of_service_prevented_int_to_str)Regression test: ensure we fail before performing O(N**2) work. ... oktest_denial_of_service_prevented_str_to_int (test.test_int.IntStrDigitLimitsTests.test_denial_of_service_prevented_str_to_int)Regression test: ensure we fail before performing O(N**2) work. ... oktest_disabled_limit (test.test_int.IntStrDigitLimitsTests.test_disabled_limit) ... oktest_int_from_other_bases (test.test_int.IntStrDigitLimitsTests.test_int_from_other_bases) ... oktest_int_max_str_digits_is_per_interpreter (test.test_int.IntStrDigitLimitsTests.test_int_max_str_digits_is_per_interpreter) ... oktest_max_str_digits (test.test_int.IntStrDigitLimitsTests.test_max_str_digits) ... oktest_max_str_digits_edge_cases (test.test_int.IntStrDigitLimitsTests.test_max_str_digits_edge_cases)Ignore the +/- sign and space padding. ... oktest_power_of_two_bases_unlimited (test.test_int.IntStrDigitLimitsTests.test_power_of_two_bases_unlimited)The limit does not apply to power of 2 bases. ... oktest_sign_not_counted (test.test_int.IntStrDigitLimitsTests.test_sign_not_counted) ... oktest_underscores_ignored (test.test_int.IntStrDigitLimitsTests.test_underscores_ignored) ... oktest_denial_of_service_prevented_int_to_str (test.test_int.IntSubclassStrDigitLimitsTests.test_denial_of_service_prevented_int_to_str)Regression test: ensure we fail before performing O(N**2) work. ... oktest_denial_of_service_prevented_str_to_int (test.test_int.IntSubclassStrDigitLimitsTests.test_denial_of_service_prevented_str_to_int)Regression test: ensure we fail before performing O(N**2) work. ... FAILtest_disabled_limit (test.test_int.IntSubclassStrDigitLimitsTests.test_disabled_limit) ... oktest_int_from_other_bases (test.test_int.IntSubclassStrDigitLimitsTests.test_int_from_other_bases) ... oktest_int_max_str_digits_is_per_interpreter (test.test_int.IntSubclassStrDigitLimitsTests.test_int_max_str_digits_is_per_interpreter) ... oktest_max_str_digits (test.test_int.IntSubclassStrDigitLimitsTests.test_max_str_digits) ... oktest_max_str_digits_edge_cases (test.test_int.IntSubclassStrDigitLimitsTests.test_max_str_digits_edge_cases)Ignore the +/- sign and space padding. ... oktest_power_of_two_bases_unlimited (test.test_int.IntSubclassStrDigitLimitsTests.test_power_of_two_bases_unlimited)The limit does not apply to power of 2 bases. ... oktest_sign_not_counted (test.test_int.IntSubclassStrDigitLimitsTests.test_sign_not_counted) ... oktest_underscores_ignored (test.test_int.IntSubclassStrDigitLimitsTests.test_underscores_ignored) ... oktest_basic (test.test_int.IntTestCases.test_basic) ... oktest_error_message (test.test_int.IntTestCases.test_error_message) ... oktest_int_base_bad_types (test.test_int.IntTestCases.test_int_base_bad_types)Not integer types are not valid bases; issue16772. ... oktest_int_base_indexable (test.test_int.IntTestCases.test_int_base_indexable) ... oktest_int_base_limits (test.test_int.IntTestCases.test_int_base_limits)Testing the supported limits of the int() base parameter. ... oktest_int_memoryview (test.test_int.IntTestCases.test_int_memoryview) ... oktest_int_returns_int_subclass (test.test_int.IntTestCases.test_int_returns_int_subclass) ... oktest_int_subclass_with_index (test.test_int.IntTestCases.test_int_subclass_with_index) ... oktest_int_subclass_with_int (test.test_int.IntTestCases.test_int_subclass_with_int) ... oktest_intconversion (test.test_int.IntTestCases.test_intconversion) ... oktest_invalid_signs (test.test_int.IntTestCases.test_invalid_signs) ... oktest_issue31619 (test.test_int.IntTestCases.test_issue31619) ... oktest_keyword_args (test.test_int.IntTestCases.test_keyword_args) ... oktest_no_args (test.test_int.IntTestCases.test_no_args) ... oktest_non_numeric_input_types (test.test_int.IntTestCases.test_non_numeric_input_types) ... oktest_small_ints (test.test_int.IntTestCases.test_small_ints) ... oktest_string_float (test.test_int.IntTestCases.test_string_float) ... oktest_underscores (test.test_int.IntTestCases.test_underscores) ... oktest_unicode (test.test_int.IntTestCases.test_unicode) ... oktest_pylong_int_divmod (test.test_int.PyLongModuleTests.test_pylong_int_divmod) ... oktest_pylong_int_to_decimal (test.test_int.PyLongModuleTests.test_pylong_int_to_decimal) ... oktest_pylong_int_to_decimal_2 (test.test_int.PyLongModuleTests.test_pylong_int_to_decimal_2) ... skipped "resource 'cpu' is not enabled"test_pylong_misbehavior_error_path_from_str (test.test_int.PyLongModuleTests.test_pylong_misbehavior_error_path_from_str) ... oktest_pylong_misbehavior_error_path_to_str (test.test_int.PyLongModuleTests.test_pylong_misbehavior_error_path_to_str) ... oktest_pylong_roundtrip (test.test_int.PyLongModuleTests.test_pylong_roundtrip) ... oktest_pylong_str_to_int (test.test_int.PyLongModuleTests.test_pylong_str_to_int) ... ok======================================================================FAIL:test_denial_of_service_prevented_str_to_int (test.test_int.IntSubclassStrDigitLimitsTests.test_denial_of_service_prevented_str_to_int)Regression test: ensure we fail before performing O(N**2) work.----------------------------------------------------------------------Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_int.py", line740, intest_denial_of_service_prevented_str_to_intself.assertLessEqual(sw_fail_extra_huge.seconds, sw_convert.seconds/2)~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:0.09443029399999858 not less than or equal to 0.022935383500000128----------------------------------------------------------------------Ran 46 tests in 1.140sFAILED (failures=1, skipped=1)test test_int failedmake:*** [Makefile:906: profile-run-stamp] Error 2

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull requestDec 6, 2025
…ale independent (python#142193)* Change to update %c to the exact time format.---------Co-authored-by: Kir Chou <note351@hotmail.com>
@gkirchougkirchou deleted the gh-129483 branchDecember 8, 2025 04:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gkirchou@pganssle@vstinner@bedevere-bot@StanFromIreland@note35
[8]ページ先頭
©2009-2026 Movatter.jp