Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.6k
[3.14] Try to fix the fix for gh-119452#142180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:3.14
Are you sure you want to change the base?
Conversation
serhiy-storchaka commentedDec 2, 2025
!buildbot AMD64 Windows11 Non-Debug |
bedevere-bot commentedDec 2, 2025
🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commitf00ef9f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142180%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Lib/http/server.py Outdated
| while (len(data)<nbytesandlen(data)!=cursizeand | ||
| cursize=min(nbytes,_MIN_READ_BUF_SIZE) | ||
| data=self.rfile.read(cursize) | ||
| while (len(data)==cursize<nbytesand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
len(data) == cursize means that we're expecting thatcursize bytes of the data arrive over the socket simultaneously, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, and this assumption was incorrect. There was another bug in the old code -- it did not work on Linux withoutfork(), becauseread(n) could return less thann bytes.#119455 fixed it, and we need to preserve this fix. I restored that code and try another approach -- using non-zero timeout.
Uh oh!
There was an error while loading.Please reload this page.