Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.5k
gh-47798: Add asubprocess.run_pipeline() API#142080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
gpshead wants to merge12 commits intopython:mainChoose a base branch fromgpshead:claude/subprocess-pipe-chaining-01R27VPueru4RfRXYDsV5TmW
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+1,187 −51
Draft
Changes from1 commit
Commits
Show all changes
12 commits Select commitHold shift + click to select a range
e3a2fbe Add subprocess.run_pipeline() for command pipe chaining
gpshead4feb2a8 Add documentation for subprocess.run_pipeline()
gpshead2a11d4b Refactor run_pipeline() to use multiplexed I/O
gpshead2470e14 Add deadlock prevention tests for run_pipeline()
gpsheade22d1da Simplify _communicate_streams() to only accept file objects
gpsheada3e98a7 Improve test_pipeline_large_data_with_stderr to use large stderr
gpshead3c28ed6 Remove obsolete XXX comment about non-blocking I/O
gpshead9f53a8e Refactor POSIX communicate I/O into shared _communicate_io_posix()
gpsheadd420f29 Fix _communicate_streams_windows to avoid blocking with large input
gpsheaddf8f082 Fix memoryview and closed stdin handling in _communicate_streams_posix
gpshead978cd76 Factor out _flush_stdin() and _make_input_view() helpers
gpshead15f8a93 Support universal_newlines and use _translate_newlines in run_pipeline
gpsheadFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Simplify _communicate_streams() to only accept file objects
Remove support for raw file descriptors in _communicate_streams(),requiring all streams to be file objects. This simplifies both theWindows and POSIX implementations by removing isinstance() checksand fd-wrapping logic.The run_pipeline() function now wraps the stderr pipe's read endwith os.fdopen() immediately after creation.This change makes _communicate_streams() more compatible withPopen.communicate() which already uses file objects, enablingpotential future refactoring to share the multiplexed I/O logic.Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.