Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-100108: Add async generators best practices section#141885

Merged
kumaraditya303 merged 14 commits intopython:mainfrom
sergey-miryanov:100108-async-gen-docs
Mar 21, 2026
Merged

GH-100108: Add async generators best practices section#141885
kumaraditya303 merged 14 commits intopython:mainfrom
sergey-miryanov:100108-async-gen-docs

Conversation

@sergey-miryanov
Copy link
Contributor

@sergey-miryanovsergey-miryanov commentedNov 23, 2025•
edited by github-actionsbot
Loading

Added section about best practices for async generators.

📚 Documentation preview 📚:https://cpython-previews--141885.org.readthedocs.build/

albertedwardson reacted with heart emoji
@sergey-miryanov
Copy link
ContributorAuthor

@kumaraditya303 Could you please take a look?

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@kumaraditya303kumaraditya303 self-assigned thisNov 24, 2025
@kumaraditya303
Copy link
Contributor

I would appreciate a review from@willingc and@gvanrossum on this.

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's great to add these explicitly to the docs!

I hope you don't mind that I have tried to correct your English grammar somewhat (mostly adding or subtracting "the").

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@gvanrossum
Copy link
Member

I'd also love to get@willingc's view on how to make this section have the right tone so as not to scare beginners away.

@sergey-miryanov
Copy link
ContributorAuthor

I hope you don't mind that I have tried to correct your English grammar somewhat (mostly adding or subtracting "the").

Thank you! I really appreciate it!

@sergey-miryanovsergey-miryanov marked this pull request as draftNovember 26, 2025 21:41
@bedevere-app
Copy link

Thanks for making the requested changes!

@gvanrossum: please review the changes made to this pull request.

@kumaraditya303kumaraditya303enabled auto-merge (squash)March 21, 2026 11:57
@kumaraditya303kumaraditya303 merged commit897fa23 intopython:mainMar 21, 2026
28 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMar 21, 2026
@miss-islington-app
Copy link

Thanks@sergey-miryanov for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 21, 2026
…H-141885)(cherry picked from commit897fa23)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 21, 2026
…H-141885)(cherry picked from commit897fa23)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

GH-146252 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMar 21, 2026
@bedevere-app
Copy link

GH-146253 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMar 21, 2026
kumaraditya303 added a commit that referenced this pull requestMar 21, 2026
) (#146252)GH-100108: Add async generators best practices section (GH-141885)(cherry picked from commit897fa23)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull requestMar 21, 2026
) (#146253)GH-100108: Add async generators best practices section (GH-141885)(cherry picked from commit897fa23)Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@sergey-miryanov
Copy link
ContributorAuthor

Thanks!

@sergey-miryanovsergey-miryanov deleted the 100108-async-gen-docs branchMarch 21, 2026 20:31
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull requestMar 22, 2026
* upstream/main: (1475 commits)  Docs: replace all `datetime` imports with `import datetime as dt` (python#145640)pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154)pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536)pythongh-140947: fix contextvars handling for server tasks in asyncio  (python#141158)pythonGH-100108: Add async generators best practices section (python#141885)pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120)pythongh-146228: Better fork support in cached FastPath (python#146231)pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229)pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230)pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165)pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396)pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201)pythongh-143930: Reject leading dashes in webbrowser URLspythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919)pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206)pythongh-146171: Fix nested AttributeError suggestions (python#146188)pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101)pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981)pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756)pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

@kumaraditya303kumaraditya303

Labels

docsDocumentation in the Doc dirskip newstopic-asyncio

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sergey-miryanov@kumaraditya303@gvanrossum@StanFromIreland@nazeerali4325-commits
[8]ページ先頭
©2009-2026 Movatter.jp