Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-141617: clarifyconcurrent.futures.ThreadPoolExecutor deadlock example#141620

Merged
picnixz merged 7 commits intopython:mainfrom
Yashp002:concfuture
Mar 9, 2026
Merged

gh-141617: clarifyconcurrent.futures.ThreadPoolExecutor deadlock example#141620
picnixz merged 7 commits intopython:mainfrom
Yashp002:concfuture

Conversation

@Yashp002
Copy link
Contributor

@Yashp002Yashp002 commentedNov 16, 2025•
edited by github-actionsbot
Loading

This PR fixes an incomplete code example in the concurrent.futures documentation.

The second example in the deadlock section was missing a.result() call on the executor.submit() invocation, which is necessary to demonstrate the deadlock behavior described in the comment.

Changes:

  • Added.result() call to complete the example in Doc/library/concurrent.futures.rst

Fixes#141617

📚 Documentation preview 📚:https://cpython-previews--141620.org.readthedocs.build/

@picnixzpicnixz self-requested a reviewNovember 30, 2025 19:40
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The other place where to add the comment was afterb = executor.submit(wait_on_a) just a few lines above not in the documentation forsubmit.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Yashp002
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@Yashp002
Copy link
ContributorAuthor

Hi@picnixz Just checking in on this PR. I'm happy to address any remaining feedback or make changes as needed. Please let me know if there's anything I should update. Thanks.

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Keep the blank lines where they are.

@picnixzpicnixz changed the titlegh-141617: Add missing result() call in concurrent.futures examplegh-141617: clarify deadlock example forconcurrent.futures.ThreadPoolExecutorMar 1, 2026
@picnixzpicnixz changed the titlegh-141617: clarify deadlock example forconcurrent.futures.ThreadPoolExecutorgh-141617: clarifyconcurrent.futures.ThreadPoolExecutor deadlock exampleMar 1, 2026
@picnixzpicnixz added the needs backport to 3.13bugs and security fixes labelMar 1, 2026
@picnixzpicnixz added the needs backport to 3.14bugs and security fixes labelMar 1, 2026
@picnixzpicnixzenabled auto-merge (squash)March 1, 2026 15:34
@Yashp002
Copy link
ContributorAuthor

@picnixz is this PR done then?

@picnixz
Copy link
Member

Hum, it should have been. Looks like the CI failed for some reaason, let me rerun it

@picnixzpicnixz merged commit171133a intopython:mainMar 9, 2026
28 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMar 9, 2026
@miss-islington-app
Copy link

Thanks@Yashp002 for the PR, and@picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 9, 2026
…lock example (pythonGH-141620)---------(cherry picked from commit 171133aa84cd2fa8738bdbb0c76435645810e8d3)Co-authored-by: Yashraj <yashrajpala8@gmail.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 9, 2026
…lock example (pythonGH-141620)---------(cherry picked from commit171133a)Co-authored-by: Yashraj <yashrajpala8@gmail.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

GH-145686 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMar 9, 2026
@bedevere-app
Copy link

GH-145687 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMar 9, 2026
picnixz added a commit that referenced this pull requestMar 9, 2026
…dlock example (GH-141620) (#145686)gh-141617: clarify `concurrent.futures.ThreadPoolExecutor` deadlock example (GH-141620)---------(cherry picked from commit171133a)Co-authored-by: Yashraj <yashrajpala8@gmail.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull requestMar 9, 2026
…dlock example (GH-141620) (#145687)gh-141617: clarify `concurrent.futures.ThreadPoolExecutor` deadlock example (GH-141620)---------(cherry picked from commit171133a)Co-authored-by: Yashraj <yashrajpala8@gmail.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incomplete example in concurrent.future documentation

2 participants

@Yashp002@picnixz
[8]ページ先頭
©2009-2026 Movatter.jp