Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-141314: Fix TextIOWrapper.tell() assertion failure with standalone carriage return#141331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mohsinm-dev wants to merge3 commits intopython:mainChoose a base branch frommohsinm-dev:fix-textio-tell-assertion-gh-141314
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
gh-141314: Fix TextIOWrapper.tell() assertion failure with standalone carriage return#141331
mohsinm-dev wants to merge3 commits intopython:mainfrommohsinm-dev:fix-textio-tell-assertion-gh-141314
+29 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…dalone carriage returnWhen TextIOWrapper.tell() is called after reading a line that ends with astandalone carriage return (\r), the tell optimization algorithm incorrectlyassumes there is buffered data to search through. This causes an assertionfailure when skip_back=1 exceeds the empty buffer size.The fix detects when next_input is empty and skips the optimization phase,falling back to the byte-by-byte decoding method which always works correctly.This properly handles the architectural constraint that buffer optimizationcannot function without buffered data.
…dalone carriage returnAdd test case and fix assertion failure in TextIOWrapper.tell() when readingfiles that end with a standalone carriage return (\r). The optimizationalgorithm incorrectly assumed buffered data would always be available,causing an assertion failure when next_input is empty.
- Remove trailing whitespace- Add missing newline at end of NEWS file
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
io.TextIOWrapper.tell()when reading files ending with standalone\rRoot Cause
The tell() optimization algorithm assumed buffered data would always be available when calculating position, but files ending with standalone
\rcreate empty snapshots, causingassert(skip_back <= PyBytes_GET_SIZE(next_input))to fail.Fix
Added check to skip optimization when
next_inputis empty, preventing the assertion failure while maintaining correct position calculation.Test Plan
test_tell_after_readline_with_crintest_textio.py_io_TextIOWrapper_tell_impl: Assertion 'skip_back <= PyBytes_GET_SIZE(next_input)' failed#141314