Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-62480: De-personalize "Mocking Unbound Methods" section inunittest.mock examples#141322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
python-cla-botbot commentedNov 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
unittest.mock examplesUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
CAM-Gerlach left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some further textual refinements and improvements
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM now, thanks@oklena !
ec85d3c intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@oklena for the PR, and@CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…unittest.mock` examples (pythonGH-141322)* Rewrite Mocking Unbound Methods paragraph to second person(cherry picked from commit ec85d3cbfe315086805c33bb64c28a8509098829)Co-authored-by: Elena O <31424287+oklena@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-141324 is a backport of this pull request to the3.14 branch. |
…unittest.mock` examples (pythonGH-141322)* Rewrite Mocking Unbound Methods paragraph to second person(cherry picked from commit ec85d3cbfe315086805c33bb64c28a8509098829)Co-authored-by: Elena O <31424287+oklena@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-141325 is a backport of this pull request to the3.13 branch. |
…`unittest.mock` examples (GH-141322) (#141324)gh-62480: De-personalize "Mocking Unbound Methods" section in `unittest.mock` examples (GH-141322)* Rewrite Mocking Unbound Methods paragraph to second person(cherry picked from commitec85d3c)Co-authored-by: Elena O <31424287+oklena@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…`unittest.mock` examples (GH-141322) (#141325)gh-62480: De-personalize "Mocking Unbound Methods" section in `unittest.mock` examples (GH-141322)* Rewrite Mocking Unbound Methods paragraph to second person(cherry picked from commitec85d3c)Co-authored-by: Elena O <31424287+oklena@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Rewrote two first sentenced and the last sentence of Mocking Unbound Methods paragraph to second person.
📚 Documentation preview 📚:https://cpython-previews--141322.org.readthedocs.build/