Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Usefor instead ofnext incontextlib.contextmanager#141275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
brandtbucher wants to merge1 commit intopython:mainChoose a base branch frombrandtbucher:contextlib
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+7 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
picnixz commentedNov 9, 2025
For tracking purposes, could you create an issue for that please? I also think it's worth a NEWS entry for people who are interested in this kind of optimization and understanding it. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
awaiting core reviewperformancePerformance or resource usage skip newsstdlibStandard Library Python modules in the Lib/ directory
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fun little optimization. According to some local microbenchmarks (basically entering and exiting context managers a million times), turning these
nextcalls intoforloops saves about 25% of the overhead this class introduces (~5% due to__enter__and ~20% due to__exit__). This is because:forloops for generators, so instead of calling through the C code fornextand re-entering the interpreter, we can "inline" the frame push instead. (This is also more JIT-friendly.)StopIterationexceptions here, just whether or not they were raised. Raising exceptions is expensive, and the interpreter has an optimization to avoid actually raisingStopIterationin normalforloops. (This is especially helpful in__exit__, where we advance the generator, expect aStopIterationto be raised, and then just throw it away!)This change isn't worth it for the
asyncvariant of this function, since neither of the above optimizations apply toasync forloops.