Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-141004: DocumentPy_HASH_* macros#141205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 7 commits intopython:mainfrompicnixz:doc/capi/hash-141004
Nov 7, 2025

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedNov 7, 2025•
edited
Loading

This one is much more tricky becausePy_HASH_EXTERNAL was never documented and not really supported in the configure script. It would require user-defined defines and other hacks.

What I can do is remove the EXTERNAL docs and make a separate bugfix.

📚 Documentation preview 📚:https://cpython-previews--141205.org.readthedocs.build/

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@picnixz
Copy link
MemberAuthor

I decided to add the two blank lines around constants. Ideally I wanted sections, but I think two blank lines are better for reading the document. With so many versionadded, it's easy to get lost.

@ZeroIntensity
Copy link
Member

I already approved this, no need to request. I'm not too familiar with this area, so I'm basically just trusting that you know what you're doing in terms of content. The format and whatnot look fine.

picnixz reacted with thumbs up emoji

@picnixzpicnixz merged commit3989e12 intopython:mainNov 7, 2025
28 checks passed
@picnixzpicnixz deleted the doc/capi/hash-141004 branchNovember 7, 2025 18:25
@picnixz
Copy link
MemberAuthor

picnixz commentedNov 7, 2025•
edited
Loading

Well.... I included a typo :D (but that's because we have confusing names!!) I will fix it tomorrow but it will be fast (so I won't backport it yet). I knew I shouldn't have left my dev session...

picnixz added a commit to picnixz/cpython that referenced this pull requestNov 8, 2025
(cherry picked from commit3989e12)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixzpicnixz added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsNov 8, 2025
@miss-islington-app
Copy link

Thanks@picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 8, 2025
(cherry picked from commit3989e12)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

GH-141224 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelNov 8, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 8, 2025
(cherry picked from commit3989e12)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

GH-141225 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelNov 8, 2025
picnixz added a commit that referenced this pull requestNov 8, 2025
*gh-141004: Document `Py_HASH_*` macros (GH-141205)(cherry picked from commit3989e12)(cherry picked from commit8cec3d3)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull requestNov 8, 2025
*gh-141004: Document `Py_HASH_*` macros (GH-141205)(cherry picked from commit3989e12)(cherry picked from commit8cec3d3)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aasland

@corona10corona10Awaiting requested review from corona10

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

@emmatypingemmatypingAwaiting requested review from emmatyping

@ZeroIntensityZeroIntensityAwaiting requested review from ZeroIntensity

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp