NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

bpo-30241: implement contextlib.AbstractAsyncContextManager#1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

1st1 merged 6 commits intopython:masterfromJelleZijlstra:aacm

Dec 14, 2017

Merged

bpo-30241: implement contextlib.AbstractAsyncContextManager#1412

1st1 merged 6 commits intopython:masterfromJelleZijlstra:aacm

Dec 14, 2017

Conversation

Copy link

Member

JelleZijlstra commentedMay 3, 2017•
edited by bedevere-bot
Loading

https://bugs.python.org/issue30241

implement contextlib.AbstractAsyncContextManager

b0f92e5

Copy link

mention-bot commentedMay 3, 2017

@JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified@ncoghlan,@birkenfeld and@rhettinger to be potential reviewers.

the-knights-who-say-ni added the CLA signed label

May 3, 2017

ilevkivskyi reviewed

May 3, 2017

View reviewed changes

Lib/contextlib.py Outdated

		def__subclasshook__(cls,C):
		ifclsisAbstractAsyncContextManager:
		if (any("__aenter__"inB.__dict__forBinC.__mro__)and
		any("__aexit__"inB.__dict__forBinC.__mro__)):

Copy link

Member

ilevkivskyiMay 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I understand you just copied this from above, but I think both should be updated to support the explicit "anti-registration"__enter__ = None pattern, like all classes incollections.abc, see_check_methods function in_collections_abc.py.

Copy link

MemberAuthor

JelleZijlstraMay 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe that should be a separate issue?AbstractContextManager should arguably be fixed even in 3.6, and this PR only targets 3.7. I can fixAbstractAsyncContextManager though.

Copy link

Member

ilevkivskyiMay 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, a separate PR for 3.6 is needed. But I think it makes sense to already fix the async version here.

Copy link

MemberAuthor

JelleZijlstraMay 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Filedhttp://bugs.python.org/issue30266 to track that.

support the "= None" pattern

9fb1028

ilevkivskyi approved these changes

May 4, 2017

View reviewed changes

Copy link

Member

gvanrossum commentedJun 9, 2017

Wait, isn't this a new feature that should go into 3.7?

Copy link

Member

ilevkivskyi commentedJun 9, 2017

Wait, isn't this a new feature that should go into 3.7?

Oh yes, sorry, this one is not urgent then.

JelleZijlstra mentioned this pull request

Jun 9, 2017

Add AsyncContextManager generic classpython/typing#438

Merged

JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request

Jun 24, 2017

add typing.AsyncContextManager and contextlib.asynccontextmanager

32977e0

Implements:-python/typing#438-python/cpython#360python/cpython#1412, which addscontextlib.AbstractAsyncContextManager, has not yet been merged.

JelleZijlstra mentioned this pull request

Jun 24, 2017

add typing.AsyncContextManager and contextlib.asynccontextmanagerpython/typeshed#1432

Merged

gvanrossum pushed a commit to python/typeshed that referenced this pull request

Jun 27, 2017

add typing.AsyncContextManager and contextlib.asynccontextmanager (#1432

22f47fd

)Implements:-python/typing#438-python/cpython#360Note thatpython/cpython#1412, which addscontextlib.AbstractAsyncContextManager, has not yet been merged.