Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-37883: Fix test_resource failures with file size limits#140872

Draft
ritesh006 wants to merge 1 commit intopython:mainfrom
ritesh006:fix-issue-37883
Draft

gh-37883: Fix test_resource failures with file size limits#140872
ritesh006 wants to merge 1 commit intopython:mainfrom
ritesh006:fix-issue-37883

Conversation

@ritesh006
Copy link

@ritesh006ritesh006 commentedNov 1, 2025•
edited by bedevere-appbot
Loading

This fixes the long-standing issue where test_resource would fail on systems with file size limitations. The solution includes:

  • ResourceLimitHelper class for safe limit manipulation
  • Dynamic test sizing based on available resources
  • Conditional test skipping with clear messages
  • Comprehensive error handling for various platforms

Tests now adapt to system constraints rather than failing.

Fixes#37883

…limitsThis fixes the long-standing issue where test_resource would failon systems with file size limitations. The solution includes:- ResourceLimitHelper class for safe limit manipulation- Dynamic test sizing based on available resources- Conditional test skipping with clear messages- Comprehensive error handling for various platformsTests now adapt to system constraints rather than failing.Fixespython#37883
@bedevere-appbedevere-appbot added the testsTests in the Lib/test dir labelNov 1, 2025
@python-cla-bot
Copy link

python-cla-botbot commentedNov 1, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@picnixzpicnixz changed the titlebpo-678264/gh-37883: Fix test_resource failures with file size limitsgh-37883: Fix test_resource failures with file size limitsNov 1, 2025
Copy link
Member

@picnixzpicnixz left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please revertall unrelated changes. Do not add docstrings to test methods because they will be rendered on failures. Do not change the skipIf/skipUnless, they are irrelevant and reduce the diff readability. Focus on fixing the tests themselves, but not refactoring the existing code (if this is needed, this must be done in a separate PR).

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz requested changes

Assignees

No one assigned

Labels

testsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_resource fails when file size is limited

2 participants

@ritesh006@picnixz
[8]ページ先頭
©2009-2026 Movatter.jp