Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-139588: Docs: Convert the execution model "textual" diagram to a visual diagram#140721

Open
adorilson wants to merge 2 commits intopython:mainfrom
adorilson:gh139588_execution_model_as_image
Open

gh-139588: Docs: Convert the execution model "textual" diagram to a visual diagram#140721
adorilson wants to merge 2 commits intopython:mainfrom
adorilson:gh139588_execution_model_as_image

Conversation

@adorilson
Copy link
Contributor

@adorilsonadorilson commentedOct 28, 2025•
edited by bedevere-appbot
Loading

It prevents LaTeX PDF build error: Too deeply nested. (Regression from#139509.).

Besides, it also makes the diagram richer.

It is an alternative to#140709.

#139588: Docs: Convert the execution model "textual" diagram to a visual diagram

imageimage

📚 Documentation preview 📚:https://cpython-previews--140721.org.readthedocs.build/

@StanFromIrelandStanFromIreland changed the titlegh139588: Docs: Convert the execution model "textual" diagram to a visual diagramgh-139588: Docs: Convert the execution model "textual" diagram to a visual diagramOct 28, 2025
@StanFromIreland
Copy link
Member

Note that the error has now been fixed by the other PR.

adorilson reacted with thumbs up emoji

Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

How does this work with translations? Is it extracted by the gettext builder?

@rffontenelle
Copy link
Contributor

gettext builder extracts the current text for translation, but the product of this pull request is not extracted for translation. (just tested)

StanFromIreland and adorilson reacted with thumbs up emoji

@StanFromIreland
Copy link
Member

StanFromIreland commentedOct 28, 2025•
edited
Loading

Thanks for testing, Rafael.

As such, I am -0 on this, although we could keep the textual ones just for translations (instead of the graphic) using the.. only:: translation tag I added recently.

@rffontenelle
Copy link
Contributor

The best would be to have this graphic but the labels translated, but I don't even know if it is possible.

adorilson and StanFromIreland reacted with thumbs up emoji

@StanFromIreland
Copy link
Member

It also breaks on EPUB:

WARNING: dot command 'dot' cannot be run (needed for graphviz output), check the graphviz_dot setting

@adorilson
Copy link
ContributorAuthor

It also breaks on EPUB:

WARNING: dot command 'dot' cannot be run (needed for graphviz output), check the graphviz_dot setting

What exactly command did you use to get this? And what SO?

I've tried on Ubuntu, but I didn't get this warning or any other indication that the build will fail. However, the generated EPUB file is broken.

@StanFromIreland
Copy link
Member

See the CI:https://github.com/python/cpython/actions/runs/18887326277/job/53905948098?pr=140721

adorilson reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adorilson@StanFromIreland@rffontenelle
[8]ページ先頭
©2009-2026 Movatter.jp