Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-140438: Properly run the asyncio REPL in REPL tests#140298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@johnslavik
Copy link
Contributor

@johnslavikjohnslavik commentedOct 18, 2025•
edited by bedevere-appbot
Loading

Mixing-i with-m asyncio first spawns the asyncio REPL. After asyncio REPL exits, it spawns the regular Python REPL.

Here we're introducing more idiomatic way to test other custom REPLs intest_repl as necessary, without needing a pseudo-terminal.

CC@ZeroIntensity (mentorship):skip issue,skip news,needs backport to 3.13,needs backport to 3.14.

ZeroIntensity reacted with thumbs up emoji
@bedevere-appbedevere-appbot added testsTests in the Lib/test dir awaiting review labelsOct 18, 2025
@ZeroIntensity
Copy link
Member

I think it would be good if you created an issue for this.

johnslavik reacted with thumbs up emoji

@johnslavikjohnslavik changed the titleProperly run the asyncio REPL in REPL testsgh-140438: Properly run the asyncio REPL in REPL testsOct 21, 2025
@johnslavik
Copy link
ContributorAuthor

I think it would be good if you created an issue for this.

@ZeroIntensity done; let's remove theskip issue label now so that the bot can do its job.

@johnslavik
Copy link
ContributorAuthor

cc@asvetlov

@ZeroIntensity
Copy link
Member

@kumaraditya303 is our primary asyncio maintainer at the moment. Kumar, are you familiar enough with the asyncio REPL to review this?

johnslavik reacted with thumbs up emoji

Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@kumaraditya303kumaraditya303 merged commit1a3da2c intopython:mainOct 23, 2025
57 checks passed
@miss-islington-app
Copy link

Thanks@bswck for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 23, 2025
(cherry picked from commit1a3da2c)Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 23, 2025
(cherry picked from commit1a3da2c)Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-app
Copy link

GH-140507 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelOct 23, 2025
@bedevere-app
Copy link

GH-140508 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelOct 23, 2025
kumaraditya303 pushed a commit that referenced this pull requestOct 23, 2025
…40508)gh-140438: properly run the asyncio REPL tests (GH-140298)(cherry picked from commit1a3da2c)Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
kumaraditya303 pushed a commit that referenced this pull requestOct 23, 2025
…40507)gh-140438: properly run the asyncio REPL tests (GH-140298)(cherry picked from commit1a3da2c)Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotARM64 MacOS M1 Refleaks NoGIL 3.13 (tier-2) has failed when building commitadf0c11.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1396/builds/1697) and take a look at the build logs.
  4. Check if the failure is related to this commit (adf0c11) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1396/builds/1697

Failed tests:

  • test.test_multiprocessing_forkserver.test_processes

Failed subtests:

  • test_repr_rlock - test.test_multiprocessing_forkserver.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line1492, intest_repr_rlockself.assertEqual('<RLock(SomeOtherThread, nonzero)>',repr(lock))~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:'<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'- <RLock(SomeOtherThread, nonzero)>+ <RLock(None, 0)>
johnslavik reacted with thumbs down emoji

@johnslavikjohnslavik deleted the properly-run-asyncio-repl-in-repl-tests branchDecember 2, 2025 00:44
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull requestDec 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnslavik@ZeroIntensity@bedevere-bot@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp