Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-140287: HandlePYTHONSTARTUP script exceptions in the asyncio REPL#140288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
johnslavik wants to merge33 commits intopython:mainChoose a base branch fromjohnslavik:asyncio-repl-handle-python-startup
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Draft
Changes from1 commit
Commits
Show all changes
33 commits Select commitHold shift + click to select a range
faa22f4 Handle `PYTHONSTARTUP` script exceptions
johnslavik5b3ad2c Add blurb
johnslavik00edac4 Use `console.showtraceback()` instead of `sys.excepthook()`
johnslavike396622 Properly run asyncio REPL in REPL tests
johnslavik4079074 Move comment to a better place
johnslavik0440d0e Add tests
johnslavikaf6f657 Merge branch 'properly-run-asyncio-repl-in-repl-tests' into asyncio-r…
johnslavik848638d Merge branch 'main' into asyncio-repl-handle-python-startup
johnslavikd158dbf Improve test structure
johnslavik9355da7 Use `SHORT_TIMEOUT`
johnslavik3dc4cac Revert "Use `SHORT_TIMEOUT`"
johnslavikc786584 Force no colorization
johnslavikb76db67 Linecache doesn't matter and shouldn't break tests
johnslavikcad1748 Don't rely on line numbering on Windows...
johnslavikd114ed5 Different names
johnslavike6e10ad Idiomatize and simplify
johnslavikac6cd83 Merge branch 'main' into asyncio-repl-handle-python-startup
johnslavik149740a Purifying `sys.path` is implied by `-P`
johnslavikbffac1c Merge branch 'main' into asyncio-repl-handle-python-startup
johnslavika4c307e Separate tests for regular and asyncio REPL
johnslavika774da5 Remove duplicate assertion
johnslavikb3ed3d4 Document `new_startup_env`
johnslavikdf6dfd8 Fix `new_startup_env` docs
johnslavikb004839 More meaningful line breaks
johnslavikce03cce Better variables
johnslavik9e92510 Use default histfile
johnslavik0a50a50 Fix newline
johnslavikf8b8d53 Use `TestCase.enterContext`
johnslavik5701fef Remove lines with ps1
johnslavik393aaad Merge branch 'main' into asyncio-repl-handle-python-startup
johnslavik875fd2a Employ `asyncio.Runner` in the asyncio REPL
johnslavik4377d82 Revert "Employ `asyncio.Runner` in the asyncio REPL"
johnslavikc4e488e Merge branch 'main' into asyncio-repl-handle-python-startup
johnslavikFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Remove duplicate assertion
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commita774da555644a953924e00d74d690843b3a31dea
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
1 change: 0 additions & 1 deletionLib/test/test_repl.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.