NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-101525: Check whether to skip functions with computed gotos during BOLT runs#140250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

stratakis wants to merge2 commits intopython:main

base:main

Choose a base branch

fromstratakis:llvm_bolt_gotos_2110

Open

gh-101525: Check whether to skip functions with computed gotos during BOLT runs#140250

stratakis wants to merge2 commits intopython:mainfromstratakis:llvm_bolt_gotos_2110

Conversation

Copy link

Contributor

stratakis commentedOct 17, 2025•
edited by bedevere-appbot
Loading

With LLVM >= 21.1.0 BOLT can handle computed gotos in PIC compiled code.

Check for the LLVM version during configure to determine if we can safely skip those functions.

This PR builds on top of#139840

Issue:Make BOLT as stable feature #101525

stratakis added2 commits

October 17, 2025 14:15

pythongh-101525: Add GCC's LTO-generated function clones, with comput…

d6da34f

…ed gotos, to BOLT skip listWhen building with --with-lto, --enable-bolt and --enable-shared, GCC createsoptimized function clones with the suffix .lto_priv.0.The sre_ucs*_match functions use computed gotos, which BOLT cannotoptimize, so their .lto_priv.0 clones must be skipped as well.Static builds and Clang's LTO implementation are not affected.

pythongh-101525: Check whether to skip functions with computed gotos …

241a541

…during BOLT runsWith LLVM >= 21.1.0 BOLT can handle computed gotos in PIC compiled code.Check for the LLVM version during configure to determine if we can safely skip those functions.

stratakis requested review fromAA-Turner,corona10,emmatyping anderlend-aasland ascode owners

October 17, 2025 12:19