Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-83714: Set os.statx() members to None if missing from stx_mask#140216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 4 commits intopython:mainfromvstinner:statx_none
Oct 20, 2025

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedOct 16, 2025
edited by bedevere-appbot
Loading

@vstinner
Copy link
MemberAuthor

See my comment#83714 (comment) for an explanation of this PR.

The PR is currently incomplete, it only supports somestx_result members such asst_atime andst_mtime.

@vstinner
Copy link
MemberAuthor

The PR is currently incomplete, it only supports some stx_result members such as st_atime and st_mtime.

I completed the PR to handle allstx_mask flags.

I didn't use these flags:

STATX_TYPE  Want stx_mode & S_IFMTSTATX_MODE  Want stx_mode & ~S_IFMT

statx manual page, up to date:https://man7.org/linux/man-pages/man2/statx.2.html

@vstinner
Copy link
MemberAuthor

@maurycy: Thanks for your review. I updated my PR.

maurycy reacted with heart emoji

@vstinnervstinner marked this pull request as ready for reviewOctober 17, 2025 01:06
STATX_GET_NSEC(st_ctime_ns,stx_ctime,STATX_CTIME)
STATX_GET_NSEC(st_mtime_ns,stx_mtime,STATX_MTIME)

/* The low 16 bits of the context pointer are the offset from the start of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I know the mask bit itself won't fit in the context pointer on 32-bit, but you could store the mask bitindex in the upper 16 bits. For example,STATX_ATIME is0x20, so you'd store5 in the upper 16 bits, and recover the mask bit as1 << i in the getter. That way you'd only need one getter per type, rather than one per member, which is a lot less code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(You probably already know, but just in case, you can get the bit index with__builtin_ctz, and both GCC and Clang will evaluate__builtin_ctz at compile time when the arguments are constant.)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I prefer to avoid bad surprises on 32-bit systems when Linux will get more bits in mask. If all bits of mask are used, there will be no remaining place for an offset. It sounds more future proof to do as i did, one function per member and put the mask and "offset" there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhaps I wasn't clear. I'm not proposing to store the mask in the context pointer; I'm proposing to store the index of the mask bit, which is a number from 0 to 31. Even if the mask were somehow extended to 64 bits in the future, the index would then be from 0 to 63, which would still easily fit.

CPython doesn't really care about code size, so I'm fine with the way you did it.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh ok. The problem is that I'm not sure that all compilers supported by Python on Linux can compute the bit position at build time.

I don't think that code size is an issue here.

jbosboom reacted with thumbs up emoji
@vstinner
Copy link
MemberAuthor

@vstinnervstinner merged commit3222ea0 intopython:mainOct 20, 2025
45 checks passed
@vstinnervstinner deleted the statx_none branchOctober 20, 2025 15:59
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull requestDec 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@maurycymaurycymaurycy left review comments

@jbosboomjbosboomjbosboom left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@maurycy@jbosboom

[8]ページ先頭

©2009-2025 Movatter.jp