NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-83714: Check for struct statx.stx_atomic_write_unit_max_opt in configure#140185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromjbosboom:statx-atomic-write-unit-max-opt

Oct 16, 2025

Merged

gh-83714: Check for struct statx.stx_atomic_write_unit_max_opt in configure#140185

vstinner merged 1 commit intopython:mainfromjbosboom:statx-atomic-write-unit-max-opt

Oct 16, 2025

Conversation

Copy link

Contributor

jbosboom commentedOct 16, 2025•
edited by github-actionsbot
Loading

stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11. That's safe at runtime because all kernels clear the reserved space in struct statx and zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids allocating another mask bit, which are a limited resource. But it also means the kernel headers don't provide a way to check whether stx_atomic_write_unit_max_opt exists, so add a configure check.

I ranmake regen-configure. I know very little about autoconf, so please check I didn't mess up.

Issue:Add os.statx() function #83714

📚 Documentation preview 📚:https://cpython-previews--140185.org.readthedocs.build/

Check for struct statx.stx_atomic_write_unit_max_opt in configure

37ebb56

stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlledby the STATX_WRITE_ATOMIC mask bit added in Linux 6.11.  That's safe atruntime because all kernels clear the reserved space in struct statx andzero is a valid value for stx_atomic_write_unit_max_opt, and it avoidsallocating another mask bit, which are a limited resource.  But it alsomeans the kernel headers don't provide a way to check whetherstx_atomic_write_unit_max_opt exists, so add a configure check.

jbosboom requested review fromAA-Turner,corona10,emmatyping anderlend-aasland ascode owners

October 16, 2025 01:13

bedevere-appbot added the awaiting review label

Oct 16, 2025

bedevere-appbot mentioned this pull request

Oct 16, 2025

Add os.statx() function#83714

Closed

Copy link

ContributorAuthor

jbosboom commentedOct 16, 2025

!buildbot AMD64 CentOS9 NoGIL 3.x

Copy link

bedevere-bot commentedOct 16, 2025

You don't have write permissions to trigger a build

jbosboom mentioned this pull request

Oct 16, 2025

gh-83714: Implement os.statx#139178

Merged

Copy link

ContributorAuthor

jbosboom commentedOct 16, 2025

#139178 failed on the AMD64 CentOS9 NoGIL 3.x (tier-1), ARM64 Raspbian Debug 3.x (tier-3) and ARM Raspbian 3.x (tier-3) buildbots. I need someone with the appropriate permissions to run those before merging.

This should be skip-news.

cmaloney reviewed

Oct 16, 2025

View reviewed changes

Copy link

Contributor

cmaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems like a reasonable approach to me; a core dev can trigger the bots to validate (although the queue can take a while to get to the top of).

I think skip news works as this is falls under "If a change is a fix (or other adjustment) to an earlier unreleased change and the original NEWS entry remains valid, then no additional entry is needed."

This comment was marked as outdated.

1 similar comment

Copy link

Member

encukou commentedOct 16, 2025

!buildbot AMD64.CentOS9.NoGIL

Copy link

bedevere-bot commentedOct 16, 2025

🤖 New build scheduled with the buildbot fleet by@encukou for commit37ebb56 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140185%2Fmerge

The command will test the builders whose names match following regular expression:AMD64.CentOS9.NoGIL

The builders matched are:

AMD64 CentOS9 NoGIL PR
AMD64 CentOS9 NoGIL Refleaks PR

encukou added the skip news label

Oct 16, 2025

vstinner approved these changes

Oct 16, 2025

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but let me check on buildbots.

bedevere-appbot added awaiting merge and removed awaiting review labels

Oct 16, 2025

Copy link

Member

vstinner commentedOct 16, 2025

!buildbot Raspbian

Copy link

bedevere-bot commentedOct 16, 2025

🤖 New build scheduled with the buildbot fleet by@vstinner for commit37ebb56 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140185%2Fmerge

The command will test the builders whose names match following regular expression:Raspbian

The builders matched are:

ARM Raspbian Linux Asan PR
ARM64 Raspbian Debug PR
ARM Raspbian PR
ARM64 Raspbian PR

Copy link

Member

encukou commentedOct 16, 2025

Buildbot issues to expect:

The refleak intest_type_aliases wasgh-139817: Fix refleak in TypeAliasType(qualname=non_string) #140197.
Some workers currently have conncetion issues and will fail intest_urllib2net.

Copy link

Member

vstinner commentedOct 16, 2025

Buildbots passed successfully:

buildbot/AMD64 CentOS9 NoGIL PR
buildbot/ARM Raspbian PR
buildbot/ARM64 Raspbian Debug PR
buildbot/ARM64 Raspbian PR

Buildbot issues to expect: The refleak in test_type_aliases was#140197.

Alright, AMD64 CentOS9 NoGIL Refleaks PR failed on an unrelated test:test_type_aliases leaked [1, 1, 1] references, sum=3.

vstinner merged commit5a31024 intopython:main

Oct 16, 2025

58 of 59 checks passed

bedevere-appbot removed the awaiting merge label

Oct 16, 2025

Copy link

Member

vstinner commentedOct 16, 2025

Merged, thanks@jbosboom.

jbosboom mentioned this pull request

Oct 21, 2025

gh-83714: Check for struct statx members in configure#140402

Merged

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request

Dec 6, 2025

pythongh-83714: Check for struct statx.stx_atomic_write_unit_max_opt …

4215e46

…in configure (python#140185)stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlledby the STATX_WRITE_ATOMIC mask bit added in Linux 6.11.  That's safe atruntime because all kernels clear the reserved space in struct statx andzero is a valid value for stx_atomic_write_unit_max_opt, and it avoidsallocating another mask bit, which are a limited resource.  But it alsomeans the kernel headers don't provide a way to check whetherstx_atomic_write_unit_max_opt exists, so add a configure check.