Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Disable Travis docs job until a fix is found#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bpo-29527: The Travis docs job is still broken. Revert previouschange (add again -W option), and disable the job instead until abetter fix is found and things calm down after the migration toGitHub.
See the latest comment on the issue, "Currently there are (...) 6,245 warnings!": I misunderstood that the "docs" job doesn't build the documentation, but only run a linter: it uses "sphinx-build -b linkcheck" which seems to exit with code 1 if there is at least one warning (if I understood correctly). |
The issue is that we're trying to be too strict to begin with; first let's make sure it can actually build, and later tighten it up. We should remove the |
Codecov Report@@ Coverage Diff @@## master #14 +/- ##==========================================- Coverage 82.37% 82.37% -0.01%========================================== Files 1427 1427 Lines 350948 350948 ==========================================- Hits 289092 289089 -3- Misses 61856 61859 +3 Continue to review full report at Codecov.
|
Use cross-platform build environment variables
14: Warn for raise with three compnents r=ltratt a=nanjekyejoannahThis makes sense at the AST hence isolated from the [other exception PR](softdevteam#12)Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
16: Warn for specific thread module methods r=ltratt a=nanjekyejoannahDont merge untilpython#13 andpython#14 are merged, some helper code cuts across.This replacespython#15 Threading module NotesPython 2:```>>> from thread import get_ident>>> from threading import get_identTraceback (most recent call last): File "<stdin>", line 1, in <module>ImportError: cannot import name get_ident>>> import threading>>> from threading import _get_ident>>>```Python 3:```>>> from threading import get_ident>>> from thread import get_identTraceback (most recent call last): File "<stdin>", line 1, in <module>ModuleNotFoundError: No module named 'thread'>```**Note:**There is no neutral way of portingCo-authored-by: Joannah Nanjekye <jnanjekye@python.org>
```$ python3 --version && uname -aPython 3.10.12Linux ip-172-31-89-138 6.2.0-1014-awspython#14~22.04.1-Ubuntu SMP Thu Oct 5 22:43:45 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux$ echo AWS-LC PYTHON; echo; ./python bench/benchmarks.py; echo; echo SYSTEM PYTHON; echo; python3 bench/benchmarks.pyAWS-LC PYTHON ALGO SIZE (B) TIME (s) ==== ======== ========TLS 0 0.000771021842956543TLS 1024 0.0007800400257110595TLS 1048576 0.0026435813903808595md5 8 1.9125938415527344e-06md5 1024 3.813743591308594e-06md5 1048576 0.0019908883571624755sha1 8 1.8870830535888672e-06sha1 1024 3.3450126647949217e-06sha1 1048576 0.001439645290374756sha256 8 1.9631385803222656e-06sha256 1024 5.374908447265625e-06sha256 1048576 0.0034945359230041505sha384 8 2.081632614135742e-06sha384 1024 4.610776901245117e-06sha384 1048576 0.002470192193984985sha512 8 2.0771026611328124e-06sha512 1024 4.634857177734375e-06sha512 1048576 0.002472785234451294sha3_256 8 2.4628639221191406e-06sha3_256 1024 6.587982177734375e-06sha3_256 1048576 0.0045334467887878415sha3_384 8 2.4132728576660156e-06sha3_384 1024 7.719039916992187e-06sha3_384 1048576 0.005894896745681763sha3_512 8 2.4335384368896486e-06sha3_512 1024 1.061868667602539e-05sha3_512 1048576 0.008451510906219482SYSTEM PYTHON ALGO SIZE (B) TIME (s) ==== ======== ========TLS 0 0.0019146842956542969TLS 1024 0.0019197502136230468TLS 1048576 0.00295937442779541md5 8 1.884937286376953e-06md5 1024 3.789663314819336e-06md5 1048576 0.00199932861328125sha1 8 1.8317699432373046e-06sha1 1024 3.321409225463867e-06sha1 1048576 0.0014382312297821045sha256 8 2.0177364349365232e-06sha256 1024 5.11932373046875e-06sha256 1048576 0.003096806049346924sha384 8 2.1207332611083983e-06sha384 1024 4.274129867553711e-06sha384 1048576 0.0020926313400268554sha512 8 2.153873443603516e-06sha512 1024 4.2979717254638674e-06sha512 1048576 0.0020925924777984617sha3_256 8 2.3796558380126953e-06sha3_256 1024 5.854606628417969e-06sha3_256 1048576 0.003778960466384888sha3_384 8 2.38037109375e-06sha3_384 1024 6.821155548095703e-06sha3_384 1048576 0.004898728609085083sha3_512 8 2.3713111877441406e-06sha3_512 1024 9.174823760986328e-06sha3_512 1048576 0.007007023334503174```
```$ python3 --version && uname -aPython 3.10.12Linux ip-172-31-89-138 6.2.0-1014-awspython#14~22.04.1-Ubuntu SMP Thu Oct 5 22:43:45 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux$ ./python bench/benchmarks.py; echo; python3 bench/benchmarks.pyOPENSSL VERSION: AWS-LC 1.19.0 ALGO SIZE (B) TIME (s) ==== ======== ========TLS 0 0.0007833797931671143TLS 1024 0.0007857415676116944TLS 1048576 0.002678983211517334md5 8 1.9640922546386718e-06md5 1024 3.949642181396484e-06md5 1048576 0.0019850776195526124sha1 8 1.847982406616211e-06sha1 1024 3.45301628112793e-06sha1 1048576 0.0014366722106933594sha256 8 1.9931793212890624e-06sha256 1024 5.559206008911133e-06sha256 1048576 0.0035069866180419923sha384 8 2.08735466003418e-06sha384 1024 4.766225814819336e-06sha384 1048576 0.0024656279087066652sha512 8 2.061605453491211e-06sha512 1024 4.767894744873047e-06sha512 1048576 0.0024675443172454833sha3_256 8 2.3877620697021486e-06sha3_256 1024 6.785154342651367e-06sha3_256 1048576 0.004528818607330322sha3_384 8 2.38800048828125e-06sha3_384 1024 7.86590576171875e-06sha3_384 1048576 0.0058933842182159425sha3_512 8 2.4230480194091797e-06sha3_512 1024 1.0911941528320313e-05sha3_512 1048576 0.008463276624679565OPENSSL VERSION: OpenSSL 3.0.2 15 Mar 2022 ALGO SIZE (B) TIME (s) ==== ======== ========TLS 0 0.0018935666084289552TLS 1024 0.0019144091606140136TLS 1048576 0.0029557681083679198md5 8 1.8961429595947266e-06md5 1024 3.826141357421875e-06md5 1048576 0.0019944441318511964sha1 8 1.855611801147461e-06sha1 1024 3.2887458801269532e-06sha1 1048576 0.001434556007385254sha256 8 1.9848346710205076e-06sha256 1024 5.077362060546875e-06sha256 1048576 0.003089451551437378sha384 8 2.099514007568359e-06sha384 1024 4.216670989990234e-06sha384 1048576 0.0020866355895996095sha512 8 2.0647048950195313e-06sha512 1024 4.217624664306641e-06sha512 1048576 0.002087009906768799sha3_256 8 2.408742904663086e-06sha3_256 1024 5.91588020324707e-06sha3_256 1048576 0.0037849726676940916sha3_384 8 2.4039745330810547e-06sha3_384 1024 6.922245025634765e-06sha3_384 1048576 0.004906209945678711sha3_512 8 2.3734569549560547e-06sha3_512 1024 9.36126708984375e-06sha3_512 1048576 0.007021739959716797```
```$ python3 --version && uname -aPython 3.10.12Linux ip-172-31-89-138 6.2.0-1014-awspython#14~22.04.1-Ubuntu SMP Thu Oct 5 22:43:45 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux$ ./python bench/benchmarks.py; echo; python3 bench/benchmarks.pyOPENSSL VERSION: AWS-LC 1.19.0 ALGO SIZE (B) TIME (s) ==== ======== ========TLS 0 0.0007833797931671143TLS 1024 0.0007857415676116944TLS 1048576 0.002678983211517334md5 8 1.9640922546386718e-06md5 1024 3.949642181396484e-06md5 1048576 0.0019850776195526124sha1 8 1.847982406616211e-06sha1 1024 3.45301628112793e-06sha1 1048576 0.0014366722106933594sha256 8 1.9931793212890624e-06sha256 1024 5.559206008911133e-06sha256 1048576 0.0035069866180419923sha384 8 2.08735466003418e-06sha384 1024 4.766225814819336e-06sha384 1048576 0.0024656279087066652sha512 8 2.061605453491211e-06sha512 1024 4.767894744873047e-06sha512 1048576 0.0024675443172454833sha3_256 8 2.3877620697021486e-06sha3_256 1024 6.785154342651367e-06sha3_256 1048576 0.004528818607330322sha3_384 8 2.38800048828125e-06sha3_384 1024 7.86590576171875e-06sha3_384 1048576 0.0058933842182159425sha3_512 8 2.4230480194091797e-06sha3_512 1024 1.0911941528320313e-05sha3_512 1048576 0.008463276624679565OPENSSL VERSION: OpenSSL 3.0.2 15 Mar 2022 ALGO SIZE (B) TIME (s) ==== ======== ========TLS 0 0.0018935666084289552TLS 1024 0.0019144091606140136TLS 1048576 0.0029557681083679198md5 8 1.8961429595947266e-06md5 1024 3.826141357421875e-06md5 1048576 0.0019944441318511964sha1 8 1.855611801147461e-06sha1 1024 3.2887458801269532e-06sha1 1048576 0.001434556007385254sha256 8 1.9848346710205076e-06sha256 1024 5.077362060546875e-06sha256 1048576 0.003089451551437378sha384 8 2.099514007568359e-06sha384 1024 4.216670989990234e-06sha384 1048576 0.0020866355895996095sha512 8 2.0647048950195313e-06sha512 1024 4.217624664306641e-06sha512 1048576 0.002087009906768799sha3_256 8 2.408742904663086e-06sha3_256 1024 5.91588020324707e-06sha3_256 1048576 0.0037849726676940916sha3_384 8 2.4039745330810547e-06sha3_384 1024 6.922245025634765e-06sha3_384 1048576 0.004906209945678711sha3_512 8 2.3734569549560547e-06sha3_512 1024 9.36126708984375e-06sha3_512 1048576 0.007021739959716797```
bpo-29527: The Travis docs job is still broken. Revert previous
change (add again -W option), and disable the job instead until a
better fix is found and things calm down after the migration to
GitHub.
The Travis "docs" job is still broken, even after the change removing the -W option:
https://travis-ci.org/python/cpython/jobs/200552343
It's too late to find a better fix. I suggest to disable the job just to fix Travis, so other jobs will be more useful, and take time later to fix this docs job.