Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
GH-139596: Cease caching config.cache & ccache in GH Actions#139623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
mhsmith commentedOct 6, 2025
For future reference:
|
| with: | ||
| path:config.cache | ||
| # Include env.pythonLocation in key to avoid changes in environment when setup-python updates Python | ||
| key:${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ needs.build-context.outputs.config-hash }}-${{ env.pythonLocation }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we also removeconfig-hash from reusable-context.yml?
c744ccb intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@AA-Turner for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry,@AA-Turner and@gpshead, I could not cleanly backport this to |
Sorry,@AA-Turner and@gpshead, I could not cleanly backport this to |
gpshead commentedNov 11, 2025
the backport labels were opportunistic checks - actions configs have been rearranged since |
…ionsManual redo/backport ofpython#139623 to 3.14.
| path:${{ env.CROSS_BUILD_WASI }}/config.cache | ||
| # Should be kept in sync with the other config.cache step above. | ||
| key:${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ env.WASI_SDK_VERSION }}-${{ env.WASMTIME_VERSION }}-${{ inputs.config_hash }}-${{ hashFiles('Tools/wasm/wasi/__main__.py') }}-${{ env.pythonLocation }} | ||
| run:python3 Tools/wasm/wasi.py make-build-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like a merge misfire:
| run:python3 Tools/wasm/wasi.py make-build-python | |
| run:python3 Tools/wasm/wasi make-build-python |
Uh oh!
There was an error while loading.Please reload this page.
This removes the
config.cacheandccachecaches from GitHub Actions. Note that we still install and useccacheviaposix-deps-apt.sh, so we will get the benefit from that still (if any), but we will no longer save it to the GHA cache.A