Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
bpo-18748: Fix _pyio.IOBase destructor (closed case)#13952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
_pyio.IOBase destructor now does nothing if getting the closedattribute fails to better mimick _io.IOBase finalizer.
vstinner added a commit that referenced this pull requestJun 12, 2019
*bpo-18748: Fix _pyio.IOBase destructor (closed case) (GH-13952)_pyio.IOBase destructor now does nothing if getting the closedattribute fails to better mimick _io.IOBase finalizer.(cherry picked from commit4f6f7c5)*bpo-37223: test_io: silence destructor errors (GH-13954)Implement also MockNonBlockWriterIO.seek() method.(cherry picked from commitb589cef)*bpo-37223, test_io: silence last 'Exception ignored in:' (GH-14029)Use catch_unraisable_exception() to ignore 'Exception ignored in:'error when the internal BufferedWriter of the BufferedRWPair isdestroyed. The C implementation doesn't give access to theinternal BufferedWriter, so just ignore the warning instead.(cherry picked from commit913fa1c)
DinoV pushed a commit to DinoV/cpython that referenced this pull requestJan 14, 2020
_pyio.IOBase destructor now does nothing if getting the closedattribute fails to better mimick _io.IOBase finalizer.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
_pyio.IOBase destructor now does nothing if getting the closed
attribute fails to better mimick _io.IOBase finalizer.
https://bugs.python.org/issue18748