Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-90949: amend GH-139234 in prevision of future mitigation API#139366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 3 commits intopython:mainfrompicnixz:feat/xml/post-139234
Sep 26, 2025

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedSep 26, 2025•
edited by github-actionsbot
Loading

There were some typos that slipped under both@hartwork's and my radar and some functions that could be made more generic and used by the next PR.

📚 Documentation preview 📚:https://cpython-previews--139366.org.readthedocs.build/

Copy link
Contributor

@hartworkhartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@picnixz looks alright with me 👍

@picnixz
Copy link
MemberAuthor

Oh thank you for the review. I pinged you on the wrong PR but you saw this one. Thanks!

hartwork reacted with thumbs up emoji

@picnixzpicnixzenabled auto-merge (squash)September 26, 2025 16:36
@picnixz
Copy link
MemberAuthor

Once this lands, we can backport this into the backports (just mention that it was also cherry-picked for another commit).

@hartwork
Copy link
Contributor

Once this lands, we can backport this into the backports (just mention that it was also cherry-picked for another commit).

@picnixz sounds like you have plaingit cherry-pick on top the existing branch in mind rather than cherry-picker. Is that what you meant?

@picnixz
Copy link
MemberAuthor

picnixz commentedSep 26, 2025•
edited
Loading

sounds like you have plain git cherry-pick on top the existing branch in mind rather than cherry-picker

yes, I don't know if cherry-picker can do multiple cherry-picks actually

hartwork reacted with thumbs up emoji

@picnixz
Copy link
MemberAuthor

Mmh, TSAN is taking an incredibly long time.

@picnixzpicnixz merged commit68a1778 intopython:mainSep 26, 2025
81 of 83 checks passed
@picnixzpicnixz deleted the feat/xml/post-139234 branchSeptember 26, 2025 18:16
hartwork pushed a commit to hartwork/cpython that referenced this pull requestSep 26, 2025
…on API (python#139366)Fix some typos left inf04bea4,and simplify some internal functions to ease maintenance of futuremitigation APIs.(cherry picked from commit68a1778)
picnixz added a commit to picnixz/cpython that referenced this pull requestSep 28, 2025
…on API (python#139366)Fix some typos left inf04bea4,and simplify some internal functions to ease maintenance of futuremitigation APIs.
hartwork pushed a commit to hartwork/cpython that referenced this pull requestOct 2, 2025
…on API (python#139366)Fix some typos left inf04bea4,and simplify some internal functions to ease maintenance of futuremitigation APIs.(cherry picked from commit68a1778)
hartwork pushed a commit to hartwork/cpython that referenced this pull requestOct 2, 2025
…on API (python#139366)Fix some typos left inf04bea4,and simplify some internal functions to ease maintenance of futuremitigation APIs.(cherry picked from commit68a1778)
hartwork pushed a commit to hartwork/cpython that referenced this pull requestOct 3, 2025
…on API (python#139366)Fix some typos left inf04bea4,and simplify some internal functions to ease maintenance of futuremitigation APIs.(cherry picked from commit68a1778)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

1 more reviewer

@hartworkhartworkhartwork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@hartwork
[8]ページ先頭
©2009-2025 Movatter.jp