Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-138489: Add missingbuild-details.json step for building wasm#139302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FFY00 merged 3 commits intopython:mainfromulagbulag:fix/wasm-build-details.json
Oct 4, 2025

Conversation

@HoKim98
Copy link
Contributor

@HoKim98HoKim98 commentedSep 24, 2025•
edited by picnixz
Loading

Hello, this PR just adds a missingbuild-details.json build step on WASM ecosystems (e.g.WASI).

When cross-compiling for WASI bybuild_wasm orbuild_emscripten, thebuild-details.json step is now included in the build process, just like with native builds.

This fixes thelibinstall task which requires thebuild-details.json file during the process.

Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@python-cla-bot
Copy link

python-cla-botbot commentedSep 24, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@HoKim98HoKim98 changed the titleAdd missingbuild-details.json step for building wasmgh-139302: Add missingbuild-details.json step for building wasmSep 24, 2025
@picnixzpicnixz changed the titlegh-139302: Add missingbuild-details.json step for building wasmgh-138489: Add missingbuild-details.json step for building wasmSep 24, 2025
@AA-Turner
Copy link
Member

Sorry, it's far too easy to click the 'copilot' button, this was absolutely not my intent!

A

HoKim98 reacted with laugh emoji

@pythonpython deleted a comment fromCopilotAISep 24, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@HoKim98HoKim98force-pushed thefix/wasm-build-details.json branch fromf9a947b to6bbad6dCompareSeptember 24, 2025 14:14

This comment was marked as spam.

@emmatyping
Copy link
Member

Confirmed locally this also fixes#137878

$wasmtime--dir/opt/wasi-python//opt/wasi-python/bin/python3.wasmPython3.15.0a0 (heads/fix/wasm-build-details.json-dirty:6bbad6d6cc2,Sep242025,10:33:33) [Clang19.1.5-wasi-sdk (https://github.com/llvm/llvm-projectab4b5a2db582958af1eonwasiType"help","copyright","credits"or"license"formoreinformation.warning:can't use pyrepl: No module named 'termios'>>>importmath>>>math.pi3.141592653589793

Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you! This looks good to me.

HoKim98 reacted with hooray emoji
Copy link
Member

@FFY00FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@HoKim98 😊

HoKim98 reacted with thumbs up emoji
@FFY00FFY00 merged commitdb53ca3 intopython:mainOct 4, 2025
45 checks passed
@AA-TurnerAA-Turner added the needs backport to 3.14bugs and security fixes labelOct 4, 2025
@miss-islington-app
Copy link

Thanks@HoKim98 for the PR, and@FFY00 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 4, 2025
…asm (pythonGH-139302)* fix: add missing `build-details.json` step for building wasmSigned-off-by: Ho Kim <ho.kim@ulagbulag.io>*pythongh-138489: Add missing build-details.json step for building wasmSigned-off-by: Ho Kim <ho.kim@ulagbulag.io>* Update Makefile.pre.inCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>---------(cherry picked from commitdb53ca3)Co-authored-by: Ho Kim <ho.kim@ulagbulag.io>Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

GH-139557 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelOct 4, 2025
@AA-Turner
Copy link
Member

I think it's worth backporting this, but it's not critical that this goes into 3.14.0. What do we think?

A

@FFY00FFY00 added the needs backport to 3.14bugs and security fixes labelOct 4, 2025
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 4, 2025
…asm (pythonGH-139302)* fix: add missing `build-details.json` step for building wasmSigned-off-by: Ho Kim <ho.kim@ulagbulag.io>*pythongh-138489: Add missing build-details.json step for building wasmSigned-off-by: Ho Kim <ho.kim@ulagbulag.io>* Update Makefile.pre.inCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>---------(cherry picked from commitdb53ca3)Co-authored-by: Ho Kim <ho.kim@ulagbulag.io>Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@miss-islington-app

This comment was marked as outdated.

@AA-Turner
Copy link
Member

Backport PR already created atGH-139557, miss-islington doesn't appear to recognise this.

A

danigm pushed a commit to openSUSE-Python/cpython that referenced this pull requestOct 7, 2025
…asm (python#139302)* fix: add missing `build-details.json` step for building wasmSigned-off-by: Ho Kim <ho.kim@ulagbulag.io>*pythongh-138489: Add missing build-details.json step for building wasmSigned-off-by: Ho Kim <ho.kim@ulagbulag.io>* Update Makefile.pre.inCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>---------Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
encukou pushed a commit that referenced this pull requestOct 7, 2025
…wasm (GH-139302) (GH-139557)(cherry picked from commitdb53ca3)Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>Co-authored-by: Ho Kim <ho.kim@ulagbulag.io>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@hugovkhugovk removed the needs backport to 3.14bugs and security fixes labelNov 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments

Copilot code reviewCopilotCopilot left review comments

@emmatypingemmatypingemmatyping approved these changes

@FFY00FFY00FFY00 approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

@FFY00FFY00

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HoKim98@AA-Turner@emmatyping@FFY00@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp