Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-139262: Prevent swallowing REPL input on Windows#139263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 3 commits intopython:mainfromchris-eibl:fix_swallowed
Jan 2, 2026

Conversation

@chris-eibl
Copy link
Member

@chris-eiblchris-eibl commentedSep 23, 2025•
edited by bedevere-appbot
Loading

Especially when using the meta (ALT) key.

For instance,Alt +b for

(r"\M-b","backward-word"),

the first hit is swallowed in a Windwos Terminal.

It happens, when there is nothing to be read from the console, i.e.

defwait(self,timeout:float|None)->bool:

returnsFalse but there is data inself.event_queue.

yihong0618 reacted with thumbs up emoji
returnFalse
returnTrue

defwait(self,timeout:float|None)->bool:
Copy link
MemberAuthor

@chris-eiblchris-eiblSep 23, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The fix is easy and brings us in sync withunix_console.py

defwait(self,timeout:float|None=None)->bool:
"""
Wait for events on the console.
"""
return (
notself.event_queue.empty()
orbool(self.pollob.poll(timeout))
)
.

yihong0618 reacted with thumbs up emoji
@chris-eibl
Copy link
MemberAuthor

macOS test_ssl failure for sure unrelated :)

@ambvambv changed the titlegh-139262: Sometimes keystrokes are swallowed in the new REPL on Windowsgh-139262: Prevent swallowing REPL input on WindowsJan 2, 2026
@ambvambv added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJan 2, 2026
@ambvambv merged commitef6f92a intopython:mainJan 2, 2026
58 checks passed
@miss-islington-app
Copy link

Thanks@chris-eibl for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 2, 2026
…39263)(cherry picked from commitef6f92a)Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@ambv
Copy link
Contributor

ambv commentedJan 2, 2026

Thanks for your fix, Chris.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 2, 2026
…39263)(cherry picked from commitef6f92a)Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

GH-143362 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJan 2, 2026
@bedevere-app
Copy link

GH-143363 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 2, 2026
ambv added a commit that referenced this pull requestJan 2, 2026
GH-143362)(cherry picked from commitef6f92a)Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull requestJan 2, 2026
GH-143363)(cherry picked from commitef6f92a)Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@chris-eiblchris-eibl deleted the fix_swallowed branchJanuary 2, 2026 16:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@ambvambvAwaiting requested review from ambvambv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chris-eibl@ambv
[8]ページ先頭
©2009-2026 Movatter.jp