Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-138891: fix star-unpack in get_annotations#138951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
JelleZijlstra merged 1 commit intopython:mainfromwiomoc:138891-fix-star-unpack-get_annotationsOct 20, 2025
Merged
gh-138891: fix star-unpack in get_annotations#138951
JelleZijlstra merged 1 commit intopython:mainfromwiomoc:138891-fix-star-unpack-get_annotationsOct 20, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
29878c8 tod6f13ecCompareJelleZijlstra approved these changesOct 20, 2025
c6be6e4 intopython:main 89 of 91 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@wiomoc for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 20, 2025
(cherry picked from commitc6be6e4)Co-authored-by: Christoph Walcher <christoph-wa@gmx.de>
GH-140384 is a backport of this pull request to the3.14 branch. |
JelleZijlstra pushed a commit that referenced this pull requestOct 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
inspect.get_annotations(eval_str=True)raisesSyntaxErrorfor PEP-646 unpacked tuple annotation*tuple[...]#138891