Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-130567: Fix possible crash in locale.strxfrm()#138940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
On some macOS versions there was an off-by-one error in wcsxfrm() whichcaused writing past the end of the array if its size was not calculatedby running wcsxfrm() first.Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
encukou approved these changesSep 23, 2025
Uh oh!
There was an error while loading.Please reload this page.
Member
encukou commentedSep 23, 2025
Looks good, thank you! |
5854cf3 intopython:main 45 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR, and@encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 23, 2025
)On some macOS versions there was an off-by-one error in wcsxfrm() whichcaused writing past the end of the array if its size was not calculatedby running wcsxfrm() first.(cherry picked from commit5854cf3)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 23, 2025
)On some macOS versions there was an off-by-one error in wcsxfrm() whichcaused writing past the end of the array if its size was not calculatedby running wcsxfrm() first.(cherry picked from commit5854cf3)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
GH-139265 is a backport of this pull request to the3.14 branch. |
GH-139266 is a backport of this pull request to the3.13 branch. |
encukou pushed a commit that referenced this pull requestSep 24, 2025
…H-139266)On some macOS versions there was an off-by-one error in wcsxfrm() whichcaused writing past the end of the array if its size was not calculatedby running wcsxfrm() first.(cherry picked from commit5854cf3)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
encukou added a commit that referenced this pull requestOct 7, 2025
…H-139265)On some macOS versions there was an off-by-one error in wcsxfrm() whichcaused writing past the end of the array if its size was not calculatedby running wcsxfrm() first.(cherry picked from commit5854cf3)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
On some macOS versions there was an off-by-one error in wcsxfrm() which caused writing past the end of the array if its size was not calculated by running wcsxfrm() first.