Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-138897: Use_pyrepl.pager for_sitebuiltins._Printer#138898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 6 commits intopython:mainfromStanFromIreland:use-pager
Jan 2, 2026

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commentedSep 14, 2025
edited
Loading

@StanFromIrelandStanFromIreland marked this pull request as ready for reviewSeptember 15, 2025 06:53
@ambv
Copy link
Contributor

Great idea, love it. In fact, you can use the pageralways since it's deliberately a rather independent part of PyREPL.pydoc is using it, too (the code was moved from there originally)

StanFromIreland reacted with heart emoji

@picnixz
Copy link
Member

picnixz commentedSep 16, 2025
edited
Loading

In fact, you can use the pager always since it's deliberately a rather independent part of PyREPL

Would it be possible to isolate it outside_pyrepl? (would it also make sense?) Since we have_colorize for colorization support,_pypager.py would make sense (I would suggest the_py prefix to be sure we don't shadow_pager.py modules from users)

StanFromIreland reacted with thumbs up emoji

@ambv
Copy link
Contributor

Would it be possible to isolate it outside_pyrepl?

Yes, I moved it out of pydoc mostly to be able to type-annotate it, change the API a bit, and make it fully independent of pydoc. I didn't want to make up a top-level module name at the time, but if it makes sense, we can do that.

StanFromIreland reacted with thumbs up emoji

@StanFromIreland
Copy link
MemberAuthor

Thanks!

@StanFromIreland
Copy link
MemberAuthor

Friendly ping@ambv :-)

@ambvambv added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJan 2, 2026
@ambvambv merged commit0417dab intopython:mainJan 2, 2026
49 checks passed
@miss-islington-app
Copy link

Thanks@StanFromIreland for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 2, 2026
…thonGH-138898)(cherry picked from commit0417dab)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

GH-143364 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJan 2, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 2, 2026
…thonGH-138898)(cherry picked from commit0417dab)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

GH-143365 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 2, 2026
ambv added a commit that referenced this pull requestJan 2, 2026
…H-138898) (GH-143364)(cherry picked from commit0417dab)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull requestJan 2, 2026
…H-138898) (GH-143365)(cherry picked from commit0417dab)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@ambvambvAwaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@ambv@picnixz

[8]ページ先頭

©2009-2026 Movatter.jp