Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-138744: GitHub Actions: pin towindows-2022#138743
Conversation
windows-22.04windows-22.04hugovk commentedSep 10, 2025
Also needed in |
windows-22.04windows-2022
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. It's a good idea to pin the Windows version and only upgrade it once it's well tested on newer Windows.
sobolevn left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! Pinning is a good idea in any case.
Question: does this new version haveos.getpid?
hugovk commentedSep 10, 2025
Looks like they both do: |
6e78a53 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12, 3.13, 3.14. |
(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sorry,@hugovk, I could not cleanly backport this to |
Sorry,@hugovk, I could not cleanly backport this to |
GH-138752 is a backport of this pull request to the3.14 branch. |
Sorry,@hugovk, I could not cleanly backport this to |
Sorry,@hugovk, I could not cleanly backport this to |
Sorry,@hugovk, I could not cleanly backport this to |
GH-138753 is a backport of this pull request to the3.13 branch. |
…GH-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…GH-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-138754 is a backport of this pull request to the3.12 branch. |
…GH-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-138755 is a backport of this pull request to the3.11 branch. |
…GH-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-138757 is a backport of this pull request to the3.10 branch. |
GH-138758 is a backport of this pull request to the3.9 branch. |
…138752)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
GitHub Actions is in the process of migrating
windows-latestfromwindows-2022towindows-2025:actions/runner-images#12677
This is causing failures for forks which have already been migrated, for example:
https://github.com/picnixz/cpython/actions/runs/17610564159/job/50031376950#step:1:9
Upstream and my fork are still on 2022, but let's pin to
windows-2022so we can separately investigate and fix for 2025, and then pin towindows-2025.test_dtracefails on Windows Server 2025 #138744