Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-138744: GitHub Actions: pin towindows-2022#138743

Merged
hugovk merged 2 commits intopython:mainfrom
hugovk:3.15-pin-windows-2022
Sep 10, 2025
Merged

gh-138744: GitHub Actions: pin towindows-2022#138743
hugovk merged 2 commits intopython:mainfrom
hugovk:3.15-pin-windows-2022

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commentedSep 10, 2025
edited by bedevere-appbot
Loading

GitHub Actions is in the process of migratingwindows-latest fromwindows-2022 towindows-2025:

This change will be rolled out over a period of several weeks beginning 2025-09-02 and will complete on 2025-09-30

actions/runner-images#12677

This is causing failures for forks which have already been migrated, for example:

======================================================================FAIL:test_function_entry_return (test.test_dtrace.DTraceNormalTests.test_function_entry_return)----------------------------------------------------------------------Traceback (most recent call last):  File"D:\a\cpython\cpython\Lib\test\test_dtrace.py", line38, innormalize_trace_output    result.sort(key=lambdarow:int(row[0]))~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"D:\a\cpython\cpython\Lib\test\test_dtrace.py", line38, in<lambda>    result.sort(key=lambdarow:int(row[0]))~~~^^^^^^^^ValueError:invalid literal for int() with base 10: 'dtrace: failed to compile script D:\\a\\cpython\\cpython\\Lib\\test\\dtracedata\\call_stack.d: line 3: pid provider is not installed on this system'During handling of the above exception, another exception occurred:Traceback (most recent call last):  File"D:\a\cpython\cpython\Lib\test\test_dtrace.py", line124, intest_function_entry_returnself.run_case("call_stack")~~~~~~~~~~~~~^^^^^^^^^^^^^^  File"D:\a\cpython\cpython\Lib\test\test_dtrace.py", line119, inrun_case    actual_output, expected_output=self.backend.run_case(~~~~~~~~~~~~~~~~~~~~~^        name, optimize_python=self.optimize_python)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"D:\a\cpython\cpython\Lib\test\test_dtrace.py", line53, inrun_case    actual_output= normalize_trace_output(self.trace_python(        script_file=abspath(name+self.EXTENSION),        python_file=abspath(name+".py"),        optimize_python=optimize_python))  File"D:\a\cpython\cpython\Lib\test\test_dtrace.py", line42, innormalize_trace_outputraiseAssertionError("tracer produced unparsable output:\n{}".format(output)    )AssertionError:tracer produced unparsable output:dtrace:failed to compile script D:\a\cpython\cpython\Lib\test\dtracedata\call_stack.d: line 3: pid provider is not installed on this system

https://github.com/picnixz/cpython/actions/runs/17610564159/job/50031376950#step:1:9

Upstream and my fork are still on 2022, but let's pin towindows-2022 so we can separately investigate and fix for 2025, and then pin towindows-2025.

@hugovkhugovk added OS-windows infraCI, GitHub Actions, buildbots, Dependabot, etc. labelsSep 10, 2025
@picnixzpicnixz changed the titleGitHub Actions: pin towindows-22.04gh-138744: GitHub Actions: pin towindows-22.04Sep 10, 2025
@hugovk
Copy link
MemberAuthor

@vstinnervstinner changed the titlegh-138744: GitHub Actions: pin towindows-22.04gh-138744: GitHub Actions: pin towindows-2022Sep 10, 2025
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. It's a good idea to pin the Windows version and only upgrade it once it's well tested on newer Windows.

zware and hugovk reacted with thumbs up emoji
Copy link
Member

@sobolevnsobolevn left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Pinning is a good idea in any case.

Question: does this new version haveos.getpid?

@hugovk
Copy link
MemberAuthor

Question: does this new version haveos.getpid?

Looks like they both do:

@hugovkhugovk merged commit6e78a53 intopython:mainSep 10, 2025
107 of 108 checks passed
@hugovkhugovk deleted the 3.15-pin-windows-2022 branchSeptember 10, 2025 14:28
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 10, 2025
(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.13

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.12

@bedevere-app
Copy link

GH-138752 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelSep 10, 2025
@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.11

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.10

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.9

@bedevere-app
Copy link

GH-138753 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelSep 10, 2025
hugovk added a commit to hugovk/cpython that referenced this pull requestSep 10, 2025
…GH-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit to hugovk/cpython that referenced this pull requestSep 10, 2025
…GH-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-138754 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 10, 2025
hugovk added a commit to hugovk/cpython that referenced this pull requestSep 10, 2025
…GH-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-138755 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelSep 10, 2025
hugovk added a commit to hugovk/cpython that referenced this pull requestSep 10, 2025
…GH-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-138757 is a backport of this pull request to the3.10 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.10only security fixes labelSep 10, 2025
hugovk added a commit to hugovk/cpython that referenced this pull requestSep 10, 2025
…H-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-138758 is a backport of this pull request to the3.9 branch.

hugovk added a commit that referenced this pull requestSep 10, 2025
…138752)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ambv pushed a commit that referenced this pull requestSep 13, 2025
ambv pushed a commit that referenced this pull requestSep 13, 2025
…H-138755)* [3.11]gh-138744: GitHub Actions: pin to `windows-2022` (GH-138743)(cherry picked from commit6e78a53)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>* Update .azure-pipelines/libffi-build.yml
ambv pushed a commit that referenced this pull requestSep 13, 2025
Yhg1s pushed a commit that referenced this pull requestSep 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments

@vstinnervstinnervstinner approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

@hugovkhugovk

Labels

infraCI, GitHub Actions, buildbots, Dependabot, etc.OS-windowsskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@vstinner@sobolevn

[8]ページ先頭

©2009-2026 Movatter.jp